From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19539 invoked by alias); 10 Jun 2014 14:49:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19529 invoked by uid 89); 10 Jun 2014 14:49:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from dns-bn1lp0143.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (207.46.163.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 10 Jun 2014 14:49:10 +0000 Received: from BL2FFO11FD025.protection.gbl (10.173.160.32) by BL2FFO11HUB049.protection.gbl (10.173.161.125) with Microsoft SMTP Server (TLS) id 15.0.959.15; Tue, 10 Jun 2014 14:49:06 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2FFO11FD025.mail.protection.outlook.com (10.173.161.104) with Microsoft SMTP Server (TLS) id 15.0.959.15 via Frontend Transport; Tue, 10 Jun 2014 14:49:06 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1WuNMg-0003Rj-Kw; Tue, 10 Jun 2014 07:49:30 -0700 From: Ajit Kumar Agarwal To: Michael Eager , "gdb-patches@sourceware.org" CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: RE: [Patch, microblaze]: Add slr and shr regs Date: Tue, 10 Jun 2014 14:49:00 -0000 References: <537EFA08.1060309@eagercon.com> <537FCEDA.9030504@eagercon.com> <2e5c185d-329c-46cf-930c-8cc2288891aa@BN1BFFO11FD019.protection.gbl> <538431FB.2070904@eagercon.com> <865132b2-a593-4147-a7c6-cee25c1ed0fd@BN1AFFO11FD052.protection.gbl> <53909299.9010105@eagerm.com> <5395FCE6.80702@eagerm.com> <539613D1.4020808@eagerm.com> <5397123C.7040907@eagerm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <3a07b07b-b3e1-4030-94f8-da6ee73b9267@BL2FFO11FD025.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438001)(189002)(24454002)(199002)(13464003)(51704005)(377454003)(479174003)(2656002)(20776003)(92726001)(23676002)(44976005)(1496006)(19580395003)(86362001)(76176999)(31696002)(19580405001)(53416003)(87936001)(50986999)(33646001)(92566001)(83322001)(85852003)(21056001)(54356999)(81342001)(70736001)(79102001)(80022001)(50466002)(81542001)(31966008)(64706001)(77982001)(74502001)(47776003)(4396001)(104016001)(83072002)(74316001)(74662001)(46102001)(6806004)(76482001)(99396002);DIR:OUT;SFP:;SCL:1;SRVR:BL2FFO11HUB049;H:xsj-pvapsmtpgw01;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-OriginatorOrg: xilinx.onmicrosoft.com X-Microsoft-Antispam: BL:0;ACTION:Default;RISK:Low;SCL:0;SPMLVL:NotSpam;PCL:0;RULEID: X-Forefront-PRVS: 0238AEEDB0 Received-SPF: Pass (: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-SW-Source: 2014-06/txt/msg00420.txt.bz2 DQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogTWljaGFlbCBF YWdlciBbbWFpbHRvOmVhZ2VyQGVhZ2VybS5jb21dDQpTZW50OiBUdWVzZGF5 LCBKdW5lIDEwLCAyMDE0IDc6NDIgUE0NClRvOiBBaml0IEt1bWFyIEFnYXJ3 YWw7IGdkYi1wYXRjaGVzQHNvdXJjZXdhcmUub3JnDQpDYzogVmlub2QgS2F0 aGFpbDsgVmlkaHVtb3VsaSBIdW5zaWdpZGE7IE5hZ2FyYWp1IE1la2FsYQ0K U3ViamVjdDogUmU6IFtQYXRjaCwgbWljcm9ibGF6ZV06IEFkZCBzbHIgYW5k IHNociByZWdzDQoNCk9uIDA2LzEwLzE0IDA2OjUwLCBBaml0IEt1bWFyIEFn YXJ3YWwgd3JvdGU6DQo+DQo+Pj4gWE1EIGlzIG5vdCBydW5uaW5nIGdkYnNl cnZlciBidWlsdCB3aXRoIHRoZXNlIHNvdXJjZXMsIGlzIGl0Pw0KPg0KPiBZ ZXMgWE1EIGlzIG5vdCBydW5uaW5nIGdkYnNlcnZlciBidWlsdCB3aXRoIHRo ZXNlIHNvdXJjZXMuDQo+DQo+Pj4gWW91ciBwYXRjaCBtb2RpZmllZCBmaWxl cyB1bmRlciBnZGIvZ2Ric2VydmVyLiAgV2hlbiB5b3UgYnVpbGQgYmludXRp bHMvZ2RiIHdpdGggLXRhcmdldD1taWNyb2JsYXplLXhpbGlueC1lbGYsIHRo ZXNlIGZpbGVzIGFyZSBub3QgYnVpbHQuDQo+DQo+IFRoZSBwYXRjaCByZWxh dGVkIHRvIGJ1aWxkaW5nIGdkYnNlcnZlciB3aXRoIHRoZSBsYXRlc3QgRlNG IFNvdXJjZXMgd2lsbCBiZSB0aGUgbmV4dCBwYXRjaCB3aGljaCBJIGFtIGdv aW5nIHRvICBzdWJtaXQgZm9yIHJldmlldy4NCg0KPj5DaGFuZ2VzIHJlbGF0 ZWQgdG8gYnVpbGRpbmcgZ2Ric2VydmVyIHNob3VsZCBiZSBzdWJtaXR0ZWQg dG9nZXRoZXIuICBJdCBzb3VuZHMgbGlrZSB0aGlzIHBhdGNoIGlzIGRlcGVu ZGVudCBvbiBzb21lIGZ1dHVyZSBwYXRjaC4NCg0KQ291bGQgeW91IHBsZWFz ZSBleHBsYWluIHdoeSB5b3UgdGhpbmsgIGJ1aWxkaW5nIGdkYnNlcnZlciBz aG91bGQgYmUgc3VibWl0dGVkIHRvZ2V0aGVyPy4gVGhpcyBwYXRjaCBpcyBy ZWxhdGVkIHRvIHRoZSBwcm9ibGVtIG9mIFJlbW90ZSBHIFBhY2tldCBlcnJv ciB3aGljaCBpcyBtYWlubHkgdGFyZ2V0ZWQgZm9yIGJhcmVtZXRhbC4NClNv bHZpbmcgdGhlIG1pc21hdGNoaW5nIGVycm9yIGJldHdlZW4gcGFja2V0cyBy ZXR1cm5pbmcgZnJvbSBYTUQgU3R1YiBhbmQgR0RCLg0KDQpUaGlzIGlzIHBs YWlubHkgaW5kZXBlbmRlbnQgb2YgdGhlICBwYXRjaCB0aGF0IGRlYWxzIHdp dGggZ2Ric2VydmVyIHBhdGNoIHdoaWNoIG1haW5seSBkZWFscyB3aXRoIG5h dGl2ZSBsaW51eCBkZWJ1Z2dpbmcgc3VwcG9ydCB3aGljaCBpcyBxdWl0ZSBp bmRlcGVuZGVudCBvZiB0aGlzIHBhdGNoLiANCg0KPj5QbGVhc2Ugc3VibWl0 IGEgcmV2aXNlZCBwYXRjaCB3aGljaCBhZGRyZXNzZXMgb25lIHByb2JsZW06 DQo+PnN1cHBvcnQgZm9yIHRoZSBhZGRlZCByZWdpc3RlcnMgaW4gTWljcm9C bGF6ZSB2OC4xMGEuICBBcyBtZW50aW9uZWQgcHJldmlvdXNseSwgZ2RiIGJ1 aWx0IHdpdGggdGhpcyBwYXRjaCBzaG91bGQgY29udGludWUgdG8gc3VwcG9y dCB0aGUgc2FtZSB2ZXJzaW9ucyBvZiBNaWNyb0JsYXplIHRoYXQgYXJlIGN1 cnJlbnRseSBzdXBwb3J0ZWQuDQoNClN1cHBvcnQgZm9yIFNIUi9TSEwgcmVn aXN0ZXJzIHdpdGggYmFyZW1ldGFsIHN1cHBvcnQgaXMgcXVpdGUgZGlmZmVy ZW50IGZyb20gdGhlIHBhdGNoIHdpdGggYnVpbGRpbmcgZ2Ric2VydmVyIGFz IFhNRCBkb2VzbuKAmXQgdXNlIHRoZSBnZGJzZXJ2ZXIgc3R1YiBmcm9tIHRo ZSBGU0Ygc291cmNlcy4gSXQgaGFzIGl0cyBvd24gZ2Ric2VydmVyIEFuZCB3 ZSBkb27igJl0IGhhdmUgcGxhbnMgdG8gcmVwbGFjZSBnZGIgU2VydmVyIGlu IFhNRCB3aXRoIGdkYnNlcnZlciBmcm9tIEZTRiBTb3VyY2VzLiBUaGUgYnVp bGRpbmcgb2YgZ2RiU2VydmVyICBmcm9tIEZTRiBpcyBtYWlubHkgcmVsYXRl ZCB0byBMaW51eCBuYXRpdmUgZGVidWdnaW5nIGFuZCB1c2UgZm9yIExpbnV4 IGltYWdlIFN1cHBvcnQgb2YgTUljcm9ibGF6ZSB3aGljaCBpcyBxdWl0ZSBp bmRlcGVuZGVudCBvZiB0aGUgcGF0Y2ggc3VibWl0dGVkIGZvciBiYXJlbWV0 YWwuDQoNCkkgZG9u4oCZdCBzZWUgYW55IHJlbGF0aW9ucyBiZXR3ZWVuIHRo ZSB0d28gYW5kIHdoeSB0aGUgcGF0Y2hlcyBzaG91bGQgYmUgc3VibWl0dGVk IHRvZ2V0aGVyLg0KLS0gDQpNaWNoYWVsIEVhZ2VyCSBlYWdlckBlYWdlcmNv bi5jb20NCjE5NjAgUGFyayBCbHZkLiwgUGFsbyBBbHRvLCBDQSA5NDMwNiAg NjUwLTMyNS04MDc3DQo= >From gdb-patches-return-113349-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jun 10 15:27:17 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 29601 invoked by alias); 10 Jun 2014 15:27:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29585 invoked by uid 89); 10 Jun 2014 15:27:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a58.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a58.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jun 2014 15:27:14 +0000 Received: from homiemail-a58.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTP id 3B3D27D806A; Tue, 10 Jun 2014 08:27:13 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTPSA id E23C77D805B; Tue, 10 Jun 2014 08:27:12 -0700 (PDT) Message-ID: <539723D0.7030505@eagerm.com> Date: Tue, 10 Jun 2014 15:27:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , "gdb-patches@sourceware.org" CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs References: <537EFA08.1060309@eagercon.com> <537FCEDA.9030504@eagercon.com> <2e5c185d-329c-46cf-930c-8cc2288891aa@BN1BFFO11FD019.protection.gbl> <538431FB.2070904@eagercon.com> <865132b2-a593-4147-a7c6-cee25c1ed0fd@BN1AFFO11FD052.protection.gbl> <53909299.9010105@eagerm.com> <5395FCE6.80702@eagerm.com> <539613D1.4020808@eagerm.com> <5397123C.7040907@eagerm.com> <3a07b07b-b3e1-4030-94f8-da6ee73b9267@BL2FFO11FD025.protection.gbl> In-Reply-To: <3a07b07b-b3e1-4030-94f8-da6ee73b9267@BL2FFO11FD025.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00421.txt.bz2 Content-length: 3020 On 06/10/14 07:49, Ajit Kumar Agarwal wrote: > > -----Original Message----- > From: Michael Eager [mailto:eager@eagerm.com] > Sent: Tuesday, June 10, 2014 7:42 PM > To: Ajit Kumar Agarwal; gdb-patches@sourceware.org > Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch, microblaze]: Add slr and shr regs > > On 06/10/14 06:50, Ajit Kumar Agarwal wrote: >> >>>> XMD is not running gdbserver built with these sources, is it? >> >> Yes XMD is not running gdbserver built with these sources. >> >>>> Your patch modified files under gdb/gdbserver. When you build binutil= s/gdb with -target=3Dmicroblaze-xilinx-elf, these files are not built. >> >> The patch related to building gdbserver with the latest FSF Sources will= be the next patch which I am going to submit for review. > >>> Changes related to building gdbserver should be submitted together. It= sounds like this patch is dependent on some future patch. > > Could you please explain why you think building gdbserver should be subm= itted together?. This patch is related to the problem of Remote G Packet er= ror which is mainly targeted for baremetal. > Solving the mismatching error between packets returning from XMD Stub and= GDB. Your patch contains changes to gdbserver. As far as you have indicated, you haven't built or tested gdbserver from these sources. > This is plainly independent of the patch that deals with gdbserver patch= which mainly deals with native linux debugging support which is quite inde= pendent of this patch. I have no idea what your future patch will contain. I don't particularly care whether you submit the gdbserver changes in this patch together with this unknown future patch, or whether you submit them as multiple patches. It appears that these changes are inappropriate for a patch which is unrelated. >>> Please submit a revised patch which addresses one problem: >>> support for the added registers in MicroBlaze v8.10a. As mentioned pre= viously, gdb built with this patch should continue to support the same vers= ions of MicroBlaze that are currently supported. > > Support for SHR/SHL registers with baremetal support is quite different f= rom the patch with building gdbserver as XMD doesn=E2=80=99t use the gdbser= ver stub from the FSF sources. It has its own gdbserver And we don=E2=80=99= t have plans to replace gdb Server in XMD with gdbserver from FSF Sources. = The building of gdbServer from FSF is mainly related to Linux native debug= ging and use for Linux image Support of MIcroblaze which is quite independe= nt of the patch submitted for baremetal. Yes, support for baremetal is quite different from Linux patches. This patch is only for baremetal support and should not contain changes to gdbserver. > I don=E2=80=99t see any relations between the two and why the patches sho= uld be submitted together. I'm asking you to have one patch address one change. --=20 Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077