From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-29685-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 17650 invoked by alias); 7 Jan 2004 19:16:19 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17639 invoked from network); 7 Jan 2004 19:16:18 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 7 Jan 2004 19:16:18 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i07JGHi27380
	for <gdb-patches@sources.redhat.com>; Wed, 7 Jan 2004 14:16:17 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i07JGBM12946;
	Wed, 7 Jan 2004 14:16:11 -0500
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i07JGAO12086;
	Wed, 7 Jan 2004 11:16:10 -0800
Message-ID: <3FFC5AFA.4050706@redhat.com>
Date: Wed, 07 Jan 2004 19:16:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624
MIME-Version: 1.0
To: =?UTF-8?B?UGF3ZcS577+9IE9zdHJvd3NraQ==?= <pasza@zodiac.mimuw.edu.pl>
CC: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] segv fix when eof is typed in actions
References: <20040102021243.GA28939@dixie.localdomain> <3FFA0BD6.70805@redhat.com> <20040106115646.GA12624@dixie.localdomain>
In-Reply-To: <20040106115646.GA12624@dixie.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2004-01/txt/msg00170.txt.bz2

Pawe� Ostrowski wrote:
> Dnia Mon, Jan 05, 2004 at 05:13:58PM -0800, Michael Snyder napisał(a):
> 
>>>GDB (snapshot 20031230) segfaults on the following script (and on any
>>>program being debugged: int main() {return 0;} is enough):
>>>
>>>trace main
>>>actions 1
>>><EOF here>
>>>
>>>I have found out that typing EOF when editing tracepoint actions
>>>causes gdb to segv. The segv is caused by dereferencing twice line
>>>parameter (**line), when *line is NULL. I have added check for this
>>>case to validate_actionline() in tracepoint.c, so it now ends actions
>>>editing (just like you would have typed "end" instead of EOF).
>>>
>>>Some details of my configuration:
>>>- gdb versions: 6.0, 20031230 snapshot, both compiled with gcc 3.3.2
>>>- uname -rmpo: 2.6.0 i686 AMD_Athlon(tm)_XP_1500+ PLD Linux
>>
>>Approved -- want me to check it in for you?
> 
> 
> Yes, please. I will be obliged for helping me in this matter.

Committed.