From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2789 invoked by alias); 5 Jan 2004 15:41:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2779 invoked from network); 5 Jan 2004 15:41:52 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Jan 2004 15:41:52 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BC1872B8F; Mon, 5 Jan 2004 10:41:49 -0500 (EST) Message-ID: <3FF985BD.3060102@gnu.org> Date: Mon, 05 Jan 2004 15:41:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/testsuite/PING] asm-source.exp: use UNTESTED References: <20040102205748.641454B35A@berman.michael-chastain.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00091.txt.bz2 > [Originally submitted 2003-12-18] > > I'm walking through the gdb.sum file for native hppa2.0w-hp-hpux11.11, > cleaning up crap in the test suite so that I can see the condition of > gdb better. So here's the first patch. > > This patch changes asm-source.exp for architectures that aren't > implemented yet. The existing code calls gdb_suppress_entire_file, a > nasty function that doesn't actually suppress any tests: it just forces > a lot of test results to FAIL. So I get: 4 ERROR, 5 WARNING, 28 FAIL, 1 > UNRESOLVED. > > My patch just reports UNTESTED and then returns. > > I think that UNTESTED is the right test result here. The dejagnu doco > says: > > @item UNTESTED > @kindex UNTESTED > @cindex untested properties > A test case is not yet complete, and in particular cannot yet produce a > @code{PASS} or @code{FAIL}. You can also use this outcome in dummy > ``tests'' that note explicitly the absence of a real test case > for a particular property. Technically yes. However, remember why this test was originally changed to fail messy - the test was being skipped and, as a demonstratable consequence, everyone chose to ignore it rather than fix the testcase :-( What about UNTESTED, and then KFAIL everything? Knowing my luck that will be much harder than it seems ... The other solution is to require people to post test results (so that they are recorded) when submitting a new architecture. > If you want the output to be WARNING and then UNTESTED, I wouldn't > object. Or if you want a FAIL in there too so that people who ignore > everything but FAIL would see it. I think UNTESTED is completely right > for this situation, but I'm flexible about happens. > > But the call to gdb_suppress_entire_file really must die. I can't deal > with 4 ERROR, 5 WARNING, 28 FAIL, and 1 UNRESOLVED just because no one > has written the assembly language test yet. And I'm not going to write > it yet because I have to deal with testing HP's compilers and assemblers > first; it can't be just another hunk of gnu assembly code with a few > opcodes changed. > > I tested this on native hppa2.0w-hp-hpux11.11, with a result > of UNTESTED. > > Okay to commit? > > Michael C > > 2003-12-17 Michael Chastain > > * gdb.asm/asm-source.exp: Return UNTESTED for platforms that > have not implemented the assembly source test. > > *** ORIGINAL-asm-source.exp 2003-12-18 01:15:58.000000000 -0500 > --- asm-source.exp 2003-12-18 01:16:07.000000000 -0500 > *************** switch -glob -- [istarget] { > *** 115,121 **** > } > > if { "${asm-arch}" == "" } { > ! gdb_suppress_entire_file "Assembly source test -- not implemented for this target." > } > > # On FreeBSD and NetBSD, crt1.o the final link will fail because of > --- 115,122 ---- > } > > if { "${asm-arch}" == "" } { > ! untested "assembly source test not implemented for this target" > ! return > } > > # On FreeBSD and NetBSD, crt1.o the final link will fail because of >