Re: [RFA] infrun.c:handle_inferior_event() tiny simplification (was "Re: [RFA/patch] handle_inferior_event() extract some code into a separate function")

Joel Brobecker
2004-01-03T15:18:13Z

> Here is what I suggest:
>
> 1. A patch to makes it more obvious that this variable is only
> locally used by defining it only inside these if blocks.
> Patch attached.
>
> 2. Send an updated version of the patch I backed out where
> real_stop_pc is local variable to the new function, rather
> than a parameter (that was completely foolish since we don't
> even use the value that was passed and was not set in any case)
>
> Here is the first patch:
>
> 2004-01-03 J. Brobecker <brobecker@gnat.com>
>
> * infrun.c (handle_inferior_event): Move the declaration of
> real_stop_pc inside the if blocks where it is used.
>
> OK to apply? Tested on x86-linux with GCC 3.2.3, no warning, and
> no regression.
>
> Sounds great to me. Consider the other patch pre-approved.

Thanks a lot. The first one has just been committed.
The second one is coming soon.

--
Joel