Re: [RFA] infrun.c:handle_inferior_event() tiny simplification (was "Re: [RFA/patch] handle_inferior_event() extract some code into a separate function")

Mark Kettenis
2004-01-03T15:09:25Z

Date: Sat, 3 Jan 2004 16:01:07 +0100
From: Joel Brobecker <brobecker@gnat.com>

> infrun.c: In function `handle_inferior_event':
> infrun.c:1337: warning: `real_stop_pc' might be used uninitialized in this function

Thanks to Mark, I looked closer to this variable. It turns out that
this variable is very locally used in two blocks of the function,
vis:

[...]

I agree with your analysis.

So the real mistake I made was to make real_stop_pc a parameter
of the new function I introduced. It should have been a local
variable to that function.

Here is what I suggest:

1. A patch to makes it more obvious that this variable is only
locally used by defining it only inside these if blocks.
Patch attached.

2. Send an updated version of the patch I backed out where
real_stop_pc is local variable to the new function, rather
than a parameter (that was completely foolish since we don't
even use the value that was passed and was not set in any case)

Here is the first patch:

2004-01-03 J. Brobecker <brobecker@gnat.com>

* infrun.c (handle_inferior_event): Move the declaration of
real_stop_pc inside the if blocks where it is used.

OK to apply? Tested on x86-linux with GCC 3.2.3, no warning, and
no regression.

Sounds great to me. Consider the other patch pre-approved.

Mark