From: Michael Snyder <msnyder@redhat.com>
To: "Dhananjay R. Deshpande" <dhananjayd@KPITCummins.com>
Cc: gdb-patches@sources.redhat.com
Subject: [PATCH] Fix problem with sim_load (h8300)
Date: Wed, 17 Dec 2003 19:54:00 -0000 [thread overview]
Message-ID: <3FE0B47C.2090701@redhat.com> (raw)
In-Reply-To: <3FE0AF2C.8020407@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
Dhananjay, this seems to fix the problem. I discovered that
in most cases people don't pass a specific bfd-target to bfd_openr.
They just let bfd figure out which target to use.
I'll give you a chance to try this out before I check it in.
Michael
[-- Attachment #2: openr --]
[-- Type: text/plain, Size: 984 bytes --]
2003-12-17 Michael Snyder <msnyder@redhat.com>
* compile.c (sim_load): Don't specify "coff-h8300" when
calling bfd_openr: we use elf now, and the norm is not to
specify a target but to let bfd figure it out.
Index: compile.c
===================================================================
RCS file: /cvs/src/src/sim/h8300/compile.c,v
retrieving revision 1.38
diff -p -r1.38 compile.c
*** compile.c 11 Dec 2003 06:21:12 -0000 1.38
--- compile.c 17 Dec 2003 19:49:33 -0000
*************** sim_load (SIM_DESC sd, char *prog, bfd *
*** 5052,5058 ****
if (abfd != NULL)
prog_bfd = abfd;
else
! prog_bfd = bfd_openr (prog, "coff-h8300");
if (prog_bfd != NULL)
{
/* Set the cpu type. We ignore failure from bfd_check_format
--- 5052,5058 ----
if (abfd != NULL)
prog_bfd = abfd;
else
! prog_bfd = bfd_openr (prog, NULL);
if (prog_bfd != NULL)
{
/* Set the cpu type. We ignore failure from bfd_check_format
next prev parent reply other threads:[~2003-12-17 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-17 5:59 H8300 Patch - Fix GDB crash problem when object file of different H8 cpu is loaded Dhananjay R. Deshpande
2003-12-17 19:32 ` Michael Snyder
2003-12-17 19:54 ` Michael Snyder [this message]
2003-12-18 5:50 [PATCH] Fix problem with sim_load (h8300) Dhananjay R. Deshpande
2003-12-24 9:23 Dhananjay R. Deshpande
2004-01-06 0:59 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FE0B47C.2090701@redhat.com \
--to=msnyder@redhat.com \
--cc=dhananjayd@KPITCummins.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox