From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29415 invoked by alias); 9 Dec 2003 22:47:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29408 invoked from network); 9 Dec 2003 22:47:48 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 9 Dec 2003 22:47:48 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BC29E2B8F; Tue, 9 Dec 2003 17:47:46 -0500 (EST) Message-ID: <3FD65112.5020106@gnu.org> Date: Tue, 09 Dec 2003 22:47:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: "J. Johnston" , David Carlton , gdb-patches@sources.redhat.com Subject: Re: [RFA]: add reason code and silent flag to decode_line_1 References: <3FD4F5D8.4000207@redhat.com> <3FD5000E.4000009@redhat.com> <3FD63D92.40808@redhat.com> <20031209212914.GA18442@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00278.txt.bz2 For the record. > On Tue, Dec 09, 2003 at 04:24:34PM -0500, J. Johnston wrote: > >> David, here is the updated patch based on your suggestion. It is >> definitely cleaner in the short-term. >> >> 2003-12-09 Jeff Johnston >> >> * linespec.h (decode_line_1): Add new not_found_ptr parameter. >> * linespec.c (decode_line_1): Add new parameter. Pass on >> new parameter to decode_variable and symtab_from_filename >> functions. >> (decode_variable): Add new not_found_ptr parameter. Throw exception >> rather than failing if the not_found_ptr is non-null and the >> function is not found. >> (symtab_from_filename): Add new not_found_ptr parametr. Throw >> exception >> rather than failing if the not_found_ptr is non-null and the >> source file is not found. >> * breakpoint.c: Change all callers of decode_line_1 to add default >> extra parameter for decode_line_1 calls. >> * tracepoint.c: Ditto. >> * cli/cli-cmds.c: Ditto. > > > You'll probably want to fix calls in Insight too. If/when Red Hat choose to contribute GDB is the time to decide if/when Jeff should be asked to fix it. Not before. Andrew