From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23179 invoked by alias); 6 Dec 2003 00:18:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23170 invoked from network); 6 Dec 2003 00:18:30 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 6 Dec 2003 00:18:30 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 01DCA80018E; Fri, 5 Dec 2003 19:18:30 -0500 (EST) Message-ID: <3FD12055.2000605@redhat.com> Date: Sat, 06 Dec 2003 00:18:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: Richard Henderson , gdb-patches@sources.redhat.com Subject: Re: [RFA]: fix ia64 long double support References: <3FCFB735.80204@redhat.com> <20031205005039.GB18170@redhat.com> <3FCFE56C.4090908@redhat.com> <1031205051806.ZM9509@localhost.localdomain> In-Reply-To: <1031205051806.ZM9509@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00232.txt.bz2 Kevin Buettner wrote: > On Dec 4, 8:54pm, J. Johnston wrote: > > >>Richard Henderson wrote: >> >>>On Thu, Dec 04, 2003 at 05:37:41PM -0500, J. Johnston wrote: >>> >>> >>>> * ia64-tdep.c (ia64_gdbarch_init): Set up the gdbarch long double >>>> format to be the i387 extended float format which is used for >>>> long double's in memory. >>> >>>This is os specific. HPUX uses ieee quad format. >>> >>>r~ >>> >> >>The Intel doc doesn't differentiate for OS. Kevin, is this something we should >>account for by calling a function in a native tdep file? > > > Hmm. I suppose we could introduce an ia64-linux-tdep.c (with the > appropriate osabi machinery) to set this for linux. If it was ever > made to work with hpux, there'd be an ia64-hpux-tdep.c file which > would set it to IEEE quad format. > > If you feel up to this, go ahead. Otherwise, just add a comment > to ia64-tdep.c which indicates that the setting is Linux specific > and that other OSes may use other types. The comment should also > indicate the correct way that it should be handled (via an OS-specific > tdep.c file.) > > Kevin > I have added a comment and checked the code in. Thanks, -- Jeff J.