Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: gdb-patches@sources.redhat.com, "J. Johnston" <jjohnstn@redhat.com>
Subject: [patch/rfc] more structs.exp kfails
Date: Thu, 04 Dec 2003 17:44:00 -0000	[thread overview]
Message-ID: <3FCF727F.6030807@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]


The attatched tweaks structs.exp so that it KFAILs the case where a 
"return struct" fails because the target hasn't implemented the relevant 
code.

Jeff and I were puzzling over an apparent regression in the ia64 - this 
better clasifies it as something that is known to have never worked.

So, jeff, if it works for you, I'll commit it in a day or so,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1760 bytes --]

2003-12-04  Andrew Cagney  <cagney@redhat.com>

	* gdb.base/structs.exp (test_struct_returns): When applicable, set
	"return_value_unimplemented".  When an unimplemented struct return
	architecture, report incorrect values as a KFAIL

Index: testsuite/gdb.base/structs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/structs.exp,v
retrieving revision 1.12
diff -u -r1.12 structs.exp
--- testsuite/gdb.base/structs.exp	27 Nov 2003 20:40:52 -0000	1.12
+++ testsuite/gdb.base/structs.exp	4 Dec 2003 16:07:14 -0000
@@ -299,6 +299,7 @@
 
     set test "return foo<n>; ${tests}"
     set return_value_unknown 0
+    set return_value_unimplemented 0
     gdb_test_multiple "return foo${n}" "${test}" {
 	-re "The location" {
 	    # Ulgh, a struct return, remember this (still need prompt).
@@ -307,10 +308,10 @@
 	}
 	-re "A structure or union" {
 	    # Ulgh, a struct return, remember this (still need prompt).
-	    # Set it to something unique so that it won't match a
-	    # struct return convention value.
-	    # set return_value_unknown -1
 	    set return_value_unknown 1
+	    # Double ulgh.  Architecture doesn't use return_value and
+	    # hence hasn't implemented small structure return.
+	    set return_value_unimplemented 1
 	    exp_continue
 	}
 	-re "Make fun${n} return now.*y or n. $" {
@@ -353,6 +354,15 @@
 		# This contradicts the above claim that GDB knew
 		# the location of the return-value.
 		fail "${test}"
+	    }
+	}
+	-re ".*${gdb_prompt} $" {
+	    if $return_value_unimplemented {
+		# What a suprize.  The architecture hasn't implemented
+		# return_value, and hence has to fail.
+		kfail "$test" gdb/1444
+	    } else {
+		fail "$test"
 	    }
 	}
     }	

             reply	other threads:[~2003-12-04 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-04 17:44 Andrew Cagney [this message]
2003-12-04 21:46 ` J. Johnston
2003-12-06 22:47   ` Andrew Cagney
2003-12-04 18:02 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FCF727F.6030807@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox