Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "J. Johnston" <jjohnstn@redhat.com>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC]: pending break support
Date: Thu, 04 Dec 2003 16:56:00 -0000	[thread overview]
Message-ID: <3FCF6724.5050109@redhat.com> (raw)
In-Reply-To: <uwu9dugop.fsf@elta.co.il>



Eli Zaretskii wrote:
>>Date: Wed, 03 Dec 2003 14:46:49 -0500
>>From: "J. Johnston" <jjohnstn@redhat.com>
>>
>>How about the following updated patch?  I tied together why I was talking about
>>the various operations on pending breakpoints which makes the grouping of the
>>information make more sense.
> 
> 
> Okay.  I'm down to nit-picking now:
> 

No problem.

> 
>>+If a specified breakpoint location cannot be found, you will be prompted
>>+as to whether you want to make the breakpoint pending on a future shared
> 
> 
> I'd replace "you will be prompted" with "@value{GDBN} will prompt
> you".  Native English speakers keep telling me that using passive
> forms is BAD.
>

Ok.

> 
>>+Normal breakpoint operations apply to pending breakpoints as well.  You may 
>>+specify, a condition for a pending breakpoint, commands to run when the 
> 
>           ^
> The comma I marked should not be there, I think.
> 

I put the comma because you can specify a condition and you can specify 
commands.  Without it, the next part of the sentence doesn't make sense.  I 
didn't want to reuse specify as that made the sentence feel redundant.  I think 
maybe the best idea would be to use "or" instead of the commas.

How about:

Normal breakpoint operations apply to pending breakpoints as well.  You may 
specify a condition for a pending breakpoint and/or commands to run when the 
breakpoint is reached.  You can also enable or disable the pending breakpoint.
...
> 

-- Jeff J.


  reply	other threads:[~2003-12-04 16:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-03  1:35 J. Johnston
2003-12-03 16:06 ` Eli Zaretskii
2003-12-03 19:46   ` J. Johnston
2003-12-04  8:30     ` Eli Zaretskii
2003-12-04 16:56       ` J. Johnston [this message]
2003-12-05  3:44         ` Daniel Jacobowitz
2003-12-05 16:09         ` Eli Zaretskii
2003-12-05  4:56 ` Daniel Jacobowitz
2003-12-10 22:17 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FCF6724.5050109@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=eliz@elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox