From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18676 invoked by alias); 3 Dec 2003 16:37:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18669 invoked from network); 3 Dec 2003 16:37:18 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 3 Dec 2003 16:37:18 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 635822B8F for ; Wed, 3 Dec 2003 11:37:18 -0500 (EST) Message-ID: <3FCE113E.8030403@gnu.org> Date: Wed, 03 Dec 2003 16:37:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [commit] Deprecate remaining STREQ uses References: <20031124165047.GA2227@nevyn.them.org> <1031124182547.ZM9776@localhost.localdomain> <3FC26407.9000704@gnu.org> <1031125000932.ZM11256@localhost.localdomain> <3FC60A75.8090803@gnu.org> <9178-Thu27Nov2003192422+0200-eliz@elta.co.il> <3FCB6275.2070403@gnu.org> <6654-Mon01Dec2003210731+0200-eliz@elta.co.il> <20031201191730.GA16428@nevyn.them.org> <3FCBB1DF.2050807@gnu.org> <20031201213202.GA5927@nevyn.them.org> <3FCD5CD9.9060500@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00080.txt.bz2 > Any change needs to be a natural part of the development cycle: > > modify > build > test > submit > review > commit > > The existing deprecate works because looking for deprecated is a relatively natural part of the patch review phase (and the issue is trivially addressed by contributors before they post their submition - if you look over the mailing lists you'll see a very high success rate and few problems with new contributors). > > Given that the ARI takes a measurable amount of time to run, it can't be addeded to the build process. However, as part of the testsuite might be more interesting: > > FAIL: number of occurances increases > KPASS: number of occurances decreased > PASS: something is zero > KFAIL: number of occurances remained static Two PSs: Even cheaper / simpler is to have financially driven corporations trying to squeeze the last drop out ofcontracts involving the maintenance of legacy code just create an internal "deprecated.h" file that contains hacks like: #define deprecated_npc_regnum npc_regnum and then #include that. While personally I'd just track the deprecated names, this is certainly a cheep option. My moving deprecated tests to the testsuite or build process the quality of code expected from GDB contributors is significantly reduced - the acceptance criteria is that they don't increase the deprecated count - _not_ that deprecated code is cleaned up as one goes. (But note this is speaking generally and not in relation to STREQ)