From: Andrew Cagney <cagney@gnu.org>
To: "Dhananjay R. Deshpande" <dhananjayd@KPITCummins.com>
Cc: Andrew Cagney <ac131313@redhat.com>,
Michael Snyder <msnyder@redhat.com>,
gdb-patches@sources.redhat.com
Subject: Re: H8300 Patch - Fix GDB crash problem when object file of different H8 cpu is loaded
Date: Mon, 01 Dec 2003 17:26:00 -0000 [thread overview]
Message-ID: <3FCB79AF.6010405@gnu.org> (raw)
In-Reply-To: <69595093233BB547BB70CF5E492B63F202FBC77C@sohm.kpit.com>
Basicly ok (and thanks), can you just change these functions:
> +int
> +is_h8300smode (void)
> +{
> + return gdbarch_bfd_arch_info (current_gdbarch)->mach == bfd_mach_h8300sx
> + || gdbarch_bfd_arch_info (current_gdbarch)->mach == bfd_mach_h8300sxn
> + || gdbarch_bfd_arch_info (current_gdbarch)->mach == bfd_mach_h8300s
> + || gdbarch_bfd_arch_info (current_gdbarch)->mach == bfd_mach_h8300sn;
> +}
> +
so that the "current_gdbarch" is passed explicitly as a parameter making
the call:
is_h8300smode (current_gdbarch)
That will save someone the effort of having to add the parameter later.
It still leaves the task of replacing current_gdbarch with something
more local at the call site, but lets leave that as a later pass.
With that change it's ok to commit.
Can you also please, as a separate patch (don't forget changelog and to
post it), add yourself to the write after approval list.
Andrew
next prev parent reply other threads:[~2003-12-01 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-01 12:58 Dhananjay R. Deshpande
2003-12-01 17:26 ` Andrew Cagney [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-17 5:59 Dhananjay R. Deshpande
2003-12-17 19:32 ` Michael Snyder
2003-12-11 6:52 Dhananjay R. Deshpande
2003-12-16 23:56 ` Michael Snyder
2003-12-10 5:06 Dhananjay R. Deshpande
2003-12-10 17:10 ` Andrew Cagney
2003-12-02 13:18 Dhananjay R. Deshpande
2003-12-03 4:24 ` Andrew Cagney
2003-11-14 8:58 Dhananjay R. Deshpande
2003-11-14 14:49 ` Andrew Cagney
2003-11-14 20:03 ` Michael Snyder
2003-11-14 20:13 ` Michael Snyder
2003-11-14 21:09 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FCB79AF.6010405@gnu.org \
--to=cagney@gnu.org \
--cc=ac131313@redhat.com \
--cc=dhananjayd@KPITCummins.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox