From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11996 invoked by alias); 27 Nov 2003 14:30:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11979 invoked from network); 27 Nov 2003 14:30:17 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 27 Nov 2003 14:30:17 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 395E52B90; Thu, 27 Nov 2003 09:30:13 -0500 (EST) Message-ID: <3FC60A75.8090803@gnu.org> Date: Thu, 27 Nov 2003 14:30:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [commit] Deprecate remaining STREQ uses References: <3FC119EB.1060102@gnu.org> <3FC234C0.1000500@gnu.org> <20031124165047.GA2227@nevyn.them.org> <1031124182547.ZM9776@localhost.localdomain> <3FC26407.9000704@gnu.org> <1031125000932.ZM11256@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00601.txt.bz2 > Even if the process isn't entirely automated, it's still sometimes > better to do the conversion all at once. By deprecating something, > you're forcing someone else (or even a later version of yourself) to > deal with the problem later on. If a contributor wants to add new code, or fix bugs in existing code, they should not be increasing the use of existing deprecated mechanisms (after all we should be able to reasonably expect contributors to not make matters worse). The prime motivator here should our joint goal to make GDB the best debgger possible, and more immediatly our desire to fix bugs such as those identified by my rewritten structs.exp. As for other code, let it bitrot and die. To give two tangable examples: http://sources.redhat.com/ml/gdb-patches/2003-08/msg00017.html > See: http://sources.redhat.com/gdb/current/ari/ > The method get_frame_saved_regs() is obsolete. Changes should be decreasing, not increasing that function's usage count :-/ The new code will need to be written in a way that avoids this method. The best way of doing this is to convert it to convert that section of the code to the new unwind mechanism. while I recommended using the new frame code, you'll note that I definitly didn't require it. There were other ways of doing this that would have reduced the deprecated count that did not involve a frame conversion. Similarly with the PPC and PPC64, you'll note that I've been fixing a depressing number of bugs in existing code, while at each step eliminating deprecated code. Andrew