From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18088 invoked by alias); 26 Nov 2003 20:02:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18059 invoked from network); 26 Nov 2003 20:02:27 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 26 Nov 2003 20:02:27 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id B508380018E; Wed, 26 Nov 2003 15:02:26 -0500 (EST) Message-ID: <3FC506D2.2020804@redhat.com> Date: Wed, 26 Nov 2003 20:02:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Thomas Fitzsimmons Cc: gdb-patches@sources.redhat.com Subject: Re: [WIP] pending breakpoint support References: <3FBAC14D.4060002@redhat.com> <20031119150659.GA14955@nevyn.them.org> <3FBBFD90.8080106@redhat.com> <3FBE95D3.4000300@redhat.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00593.txt.bz2 Thomas Fitzsimmons wrote: > On Fri, 21 Nov 2003 17:46:43 -0500, J. Johnston wrote: > > >>I have appended a patch to replace the previous hack. I changed the >>code so it supports conditionals and doesn't fail if you specify >>source:line breakpoints. I also changed the mechanism to add a new flag >>to the breakpoint struct called "pending". As you will notice, this >>adds a large number of checks because you can't just check for >>enable_state == bp_enabled without also checking for the pending flag. >>I think that having two more enable states would have been simpler, but >>I will let all of you decide. With this change, you can enable/disable >>the pending breakpoint and see any conditionals attached to it. Commands >>should also work. >> > > > I've been using this patch since it was posted and it is very useful for > both Mozilla and libgcj debugging. One minor UI nit: I don't think I > should be asked whether to make a breakpoint pending; I think the > "pending" message is enough (or maybe the behaviour could be > configurable). > IMO, the query should be the default. If there is no query, every time you make a mistake, you would end up with an unwanted pending breakpoint. Anybody, feel free to jump in with your comments. Regarding the annoyance of having to answer many queries, this could be addressed in the future with a new setting, but that should be kept separate from the initial base implementation. The query is not required for .gdbinit or mi. -- Jeff J. > In any case, even in its current early form, this patch is a huge > improvement for shared-library debugging. >