From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23106 invoked by alias); 25 Nov 2003 01:33:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23099 invoked from network); 25 Nov 2003 01:33:47 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 25 Nov 2003 01:33:47 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DBDEC2B8F; Mon, 24 Nov 2003 20:33:43 -0500 (EST) Message-ID: <3FC2B177.7080100@gnu.org> Date: Tue, 25 Nov 2003 01:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Deprecate remaining STREQ uses References: <3FC119EB.1060102@gnu.org> <3FC234C0.1000500@gnu.org> <20031124165047.GA2227@nevyn.them.org> <1031124182547.ZM9776@localhost.localdomain> <3FC26AD4.1040704@gnu.org> <1031124235641.ZM11194@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00553.txt.bz2 > On Nov 24, 3:32pm, Andrew Cagney wrote: > > >> > I too would like to see discussion over whether a particular interface >> > ought to be deprecated or outright replaced instead of presenting the >> > renaming as a fait accompli. > >> >> Please explain. > > > This STREQ issue is a good example. You chose to post an already > committed patch which did the renaming instead of first discussing the > approaches by which STREQ could be eliminated. IMO, it would have been > better to discuss the matter first and arrive at a consensus on how it > should be eliminated. (Or even if it should be eliminated.) Are you talking generally or just in terms of STREQ? STREQ is somewhat a-typical in that my earlier "obish" s/STREQ/strcmp/ changes met with zero comment (objection or thanks) - consequently I don't think it was totally unreasonable of me to assume that deprecating the remainder would be safe. It wasn't. "oops". Andrew