From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 819 invoked by alias); 22 Nov 2003 16:11:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 807 invoked from network); 22 Nov 2003 16:11:03 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.0.121) by sources.redhat.com with SMTP; 22 Nov 2003 16:11:03 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6D83B2B8F; Sat, 22 Nov 2003 11:11:01 -0500 (EST) Message-ID: <3FBF8A95.2050201@gnu.org> Date: Sat, 22 Nov 2003 16:11:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [ob] Delete PROLOGUE_FIRSTLINE_OVERLAP References: <3FBF8844.10007@gnu.org> Content-Type: multipart/mixed; boundary="------------060502010003020904010605" X-SW-Source: 2003-11/txt/msg00466.txt.bz2 This is a multi-part message in MIME format. --------------060502010003020904010605 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 10 patch ... --------------060502010003020904010605 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 2678 2003-11-22 Andrew Cagney * config/powerpc/tm-linux.h (PROLOGUE_FIRSTLINE_OVERLAP): Delete #if 0'ed macro. * infrun.c (step_into_function): Delete #ifdef PROLOGUE_FIRSTLINE_OVERLAP code. * symtab.c (find_function_start_sal): Ditto. Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.119 diff -u -r1.119 infrun.c --- infrun.c 14 Nov 2003 21:22:42 -0000 1.119 +++ infrun.c 22 Nov 2003 15:57:29 -0000 @@ -2727,15 +2727,10 @@ /* If the prologue ends in the middle of a source line, continue to the end of that source line (if it is still within the function). Otherwise, just go to end of prologue. */ -#ifdef PROLOGUE_FIRSTLINE_OVERLAP - /* no, don't either. It skips any code that's legitimately on the - first line. */ -#else if (ecs->sal.end && ecs->sal.pc != ecs->stop_func_start && ecs->sal.end < ecs->stop_func_end) ecs->stop_func_start = ecs->sal.end; -#endif if (ecs->stop_func_start == stop_pc) { Index: symtab.c =================================================================== RCS file: /cvs/src/src/gdb/symtab.c,v retrieving revision 1.122 diff -u -r1.122 symtab.c --- symtab.c 8 Nov 2003 00:13:03 -0000 1.122 +++ symtab.c 22 Nov 2003 15:57:46 -0000 @@ -2314,10 +2314,6 @@ } sal = find_pc_sect_line (pc, SYMBOL_BFD_SECTION (sym), 0); -#ifdef PROLOGUE_FIRSTLINE_OVERLAP - /* Convex: no need to suppress code on first line, if any */ - sal.pc = pc; -#else /* Check if SKIP_PROLOGUE left us in mid-line, and the next line is still part of the same function. */ if (sal.pc != pc @@ -2330,7 +2326,6 @@ sal = find_pc_sect_line (pc, SYMBOL_BFD_SECTION (sym), 0); } sal.pc = pc; -#endif return sal; } Index: config/powerpc/tm-linux.h =================================================================== RCS file: /cvs/src/src/gdb/config/powerpc/tm-linux.h,v retrieving revision 1.16 diff -u -r1.16 tm-linux.h --- config/powerpc/tm-linux.h 6 Nov 2003 03:29:49 -0000 1.16 +++ config/powerpc/tm-linux.h 22 Nov 2003 15:57:47 -0000 @@ -43,13 +43,6 @@ #define CANNOT_STORE_REGISTER(regno) ((regno) >= MQ_REGNUM) #endif -#if 0 /* If skip_prologue() isn't too greedy, we don't need this */ -/* There is some problem with the debugging symbols generated by the - compiler such that the debugging symbol for the first line of a - function overlap with the function prologue. */ -#define PROLOGUE_FIRSTLINE_OVERLAP -#endif - /* N_FUN symbols in shared libaries have 0 for their values and need to be relocated. */ #define SOFUN_ADDRESS_MAYBE_MISSING --------------060502010003020904010605--