From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32042 invoked by alias); 20 Nov 2003 21:54:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31963 invoked from network); 20 Nov 2003 21:54:42 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 20 Nov 2003 21:54:42 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3AA662B8F; Thu, 20 Nov 2003 16:54:33 -0500 (EST) Message-ID: <3FBD3819.1020302@gnu.org> Date: Thu, 20 Nov 2003 21:54:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-o64-extract-return-value References: <3FBC13EC.1040202@redhat.com> <3FBC1782.3000908@gnu.org> <3FBD31F5.6080201@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00432.txt.bz2 > Andrew Cagney wrote: > Hi Andrew, > > This change fixes 100s of FAILs for mips64-elf, 'cause gdb can't > find the function's return value. It follows some work that you > were apparently doing w.r.t. the mips internal register representation. > > I suspect that the same thing needs to be done for mips_eabi_extract..., > but I haven't tested that. What do you think? > > > Ok. > > I'll probably try doing something similar for store_return_value too. > > > Rather than doing the same thing for store_return_value, take a look at the PPC's "ppc_sysv_abi_return_value". > > Grep grep... ah, you mean ppc_sysv_abi_STORE_return_value. > Shall I fix your change log entries for you? ;-) no? $ grep ppc_sysv_abi_store_return_value ChangeLog (ppc_sysv_abi_store_return_value): Delete function. (ppc_sysv_abi_store_return_value): Delete. * ppc-tdep.h: (ppc_sysv_abi_store_return_value): Declare. (ppc_sysv_abi_store_return_value): New function. $ grep ppc_sysv_store_return_value *.c In the MIPS, take a look at n32/n64 and o32 which I previously cleaned up (probably time to s/ xfer_return_value / return_value /). That just leaves o64 and eabi (which are still riddled with deprecated code) :-( Andrew