From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3311 invoked by alias); 20 Nov 2003 01:08:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3302 invoked from network); 20 Nov 2003 01:08:02 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 20 Nov 2003 01:08:02 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hAK17xH23242 for ; Wed, 19 Nov 2003 20:07:59 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hAK17va22118; Wed, 19 Nov 2003 20:07:57 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id hAK17vH25823; Wed, 19 Nov 2003 17:07:57 -0800 Message-ID: <3FBC13EC.1040202@redhat.com> Date: Thu, 20 Nov 2003 01:08:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, cagney Subject: [RFA] mips-o64-extract-return-value Content-Type: multipart/mixed; boundary="------------050609050409040205080600" X-SW-Source: 2003-11/txt/msg00414.txt.bz2 This is a multi-part message in MIME format. --------------050609050409040205080600 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 416 Hi Andrew, This change fixes 100s of FAILs for mips64-elf, 'cause gdb can't find the function's return value. It follows some work that you were apparently doing w.r.t. the mips internal register representation. I suspect that the same thing needs to be done for mips_eabi_extract..., but I haven't tested that. What do you think? I'll probably try doing something similar for store_return_value too. Michael --------------050609050409040205080600 Content-Type: text/plain; name="extract" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="extract" Content-length: 1165 2003-11-19 Michael Snyder * mips-tdep.c (mips_o64_extract_return_value): Correct for raw reg / virtual reg scheme. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.254 diff -p -r1.254 mips-tdep.c *** mips-tdep.c 16 Nov 2003 22:46:49 -0000 1.254 --- mips-tdep.c 20 Nov 2003 01:00:31 -0000 *************** mips_o64_extract_return_value (struct ty *** 4681,4692 **** return_value_location (valtype, &hi, &lo); memcpy (valbuf + lo.buf_offset, ! regbuf + DEPRECATED_REGISTER_BYTE (lo.reg) + lo.reg_offset, lo.len); if (hi.len > 0) memcpy (valbuf + hi.buf_offset, ! regbuf + DEPRECATED_REGISTER_BYTE (hi.reg) + hi.reg_offset, hi.len); } --- 4681,4692 ---- return_value_location (valtype, &hi, &lo); memcpy (valbuf + lo.buf_offset, ! regbuf + DEPRECATED_REGISTER_BYTE (NUM_REGS + lo.reg) + lo.reg_offset, lo.len); if (hi.len > 0) memcpy (valbuf + hi.buf_offset, ! regbuf + DEPRECATED_REGISTER_BYTE (NUM_REGS + hi.reg) + hi.reg_offset, hi.len); } --------------050609050409040205080600--