From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2488 invoked by alias); 19 Nov 2003 19:38:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2450 invoked from network); 19 Nov 2003 19:38:02 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 19 Nov 2003 19:38:02 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 60CC02B8F; Wed, 19 Nov 2003 14:37:58 -0500 (EST) Message-ID: <3FBBC696.9060102@redhat.com> Date: Wed, 19 Nov 2003 19:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Pass gdbarch, not regset, to supply regset et.al.? Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00405.txt.bz2 Mark, I'm wondering if it would be easier to explicitly pass the gdbarch instead of the regset to the regset function? At present the lookup regset code does this: tdep->gregset = XMALLOC (struct regset); tdep->gregset->descr = tdep; tdep->gregset->supply_regset = i386_supply_gregset; so that the architecture is tunneled through to the regset function. const struct gdbarch_tdep *tdep = regset->descr; ... for (i = 0; i < tdep->gregset_num_regs; i++) I'm wondering if it would be easier to just pass the architecture? At the same time, I'm wondering if i386_regset_from_core_section should be abstracted a little so that, like reggroups it was set up: set_regset_supply_core_section (arch, ".reg", size, i386_supply_regset); set_regset_supply_core_section (arch, ".reg2", i386_supply_fpregset); ... f = regset_supply_from_core_section (core_arch, ".name", length); f (core_arch, current_regcache, regnum, contents, length); ... or even the short cut ... regset_supply_core_section (core_arch, ".name", current_regcache, regnum, contents, length); Thoughts? I just came across this bit of PPC64 GNU/Linux code > void > ppc_linux_supply_gregset (char *buf) > { > int regi; > struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); > > for (regi = 0; regi < 32; regi++) > supply_register (regi, buf + 4 * regi); (yes, that's a "4" not "8") and was studying the new mechanism. Andrew