Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix backtrace/1435
Date: Mon, 17 Nov 2003 22:27:00 -0000	[thread overview]
Message-ID: <3FB94B63.7000906@gnu.org> (raw)
In-Reply-To: <200311172135.hAHLZl0n009190@elgar.kettenis.dyndns.org>

> This patch fixes backtrace/1435.  The failure occurs when main
> immediately follows a function (say foo) which has its epilogue
> optimized out by the compiler.  In that case the backtrace will be
> terminated prematurely since get_frame_pc on foo's frame will return
> the address of the first instruction of main.  This can be fixed by
> using get_frame_address_in_block.
> 
> Ok to check this in?

Yes, but with more comments :-)

> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* frame.c (get_prev_frame): Use result from
> 	get_frame_address_in_block instead of get_frame_pc as argument to
> 	inside_main_func.
> 

Andrew



  reply	other threads:[~2003-11-17 22:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-17 21:35 Mark Kettenis
2003-11-17 22:27 ` Andrew Cagney [this message]
2003-11-19 17:36   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FB94B63.7000906@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox