From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32172 invoked by alias); 16 Nov 2003 14:33:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32163 invoked from network); 16 Nov 2003 14:33:03 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.0.121) by sources.redhat.com with SMTP; 16 Nov 2003 14:33:03 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2F01D2B8F for ; Sun, 16 Nov 2003 09:33:00 -0500 (EST) Message-ID: <3FB78A9C.4030205@gnu.org> Date: Sun, 16 Nov 2003 14:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [commit] Eliminate mips_register_byte Content-Type: multipart/mixed; boundary="------------060708050401040300050601" X-SW-Source: 2003-11/txt/msg00339.txt.bz2 This is a multi-part message in MIME format. --------------060708050401040300050601 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 77 This deletes mips_register_byte. It's no longer needed. committed, Andrew --------------060708050401040300050601 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 5400 2003-11-16 Andrew Cagney * mips-tdep.c (mips_register_byte): Delete function. (mips_gdbarch_init): Do not set "deprecated_register_byte". * config/mips/tm-mips.h (MIPS_REGISTER_BYTE): Delete macro. * config/mips/tm-irix6.h (MIPS_REGISTER_BYTE): Delete macro. * config/mips/tm-irix5.h (MIPS_REGISTER_BYTE): Delete macro. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.250 diff -u -r1.250 mips-tdep.c --- mips-tdep.c 16 Nov 2003 05:57:08 -0000 1.250 +++ mips-tdep.c 16 Nov 2003 14:22:59 -0000 @@ -656,37 +656,6 @@ internal_error (__FILE__, __LINE__, "Register %d out of range", regnum); } -/* Register offset in a buffer for each register. - - FIXME: cagney/2003-06-15: This is so bogus. Instead REGISTER_TYPE - should strictly return the layout of the buffer. Unfortunately - remote.c and the MIPS have come to rely on a custom layout that - doesn't 1:1 map onto the register type. */ - -static int -mips_register_byte (int regnum) -{ - gdb_assert (regnum >= 0); - if (regnum < NUM_REGS) - /* Pick up the relevant per-tm file register byte method. */ - return MIPS_REGISTER_BYTE (regnum); - else if (regnum < 2 * NUM_REGS) - { - int reg; - int byte; - /* Start with the end of the raw register buffer - assum that - MIPS_REGISTER_BYTE (NUM_REGS) returns that end. */ - byte = MIPS_REGISTER_BYTE (NUM_REGS); - /* Add space for all the proceeding registers based on their - real size. */ - for (reg = NUM_REGS; reg < regnum; reg++) - byte += TYPE_LENGTH (gdbarch_register_type (current_gdbarch, reg)); - return byte; - } - else - internal_error (__FILE__, __LINE__, "Register %d out of range", regnum); -} - /* Convert between RAW and VIRTUAL registers. The RAW register size defines the remote-gdb packet. */ @@ -5835,7 +5804,6 @@ set_gdbarch_double_bit (gdbarch, 64); set_gdbarch_long_double_bit (gdbarch, 64); set_gdbarch_deprecated_register_raw_size (gdbarch, mips_register_raw_size); - set_gdbarch_deprecated_register_byte (gdbarch, mips_register_byte); set_gdbarch_register_reggroup_p (gdbarch, mips_register_reggroup_p); set_gdbarch_pseudo_register_read (gdbarch, mips_pseudo_register_read); set_gdbarch_pseudo_register_write (gdbarch, mips_pseudo_register_write); Index: config/mips/tm-irix5.h =================================================================== RCS file: /cvs/src/src/gdb/config/mips/tm-irix5.h,v retrieving revision 1.14 diff -u -r1.14 tm-irix5.h --- config/mips/tm-irix5.h 16 Nov 2003 04:57:25 -0000 1.14 +++ config/mips/tm-irix5.h 16 Nov 2003 14:22:59 -0000 @@ -67,26 +67,6 @@ #define SIGFRAME_REGSAVE_OFF (SIGFRAME_BASE + 3 * 4) #define SIGFRAME_FPREGSAVE_OFF (SIGFRAME_BASE + 3 * 4 + 32 * 4 + 4) -/* FIXME: cagney/2000-04-04: Testing the _MIPS_SIM_NABI32 and - _MIPS_SIM in a tm-*.h file is simply wrong! Those are - host-dependant macros (provided by /usr/include) and stop any - chance of the target being cross compiled */ -#if defined (_MIPS_SIM_NABI32) && _MIPS_SIM == _MIPS_SIM_NABI32 -/* - * Irix 6 (n32 ABI) has 32-bit GP regs and 64-bit FP regs - */ - -#undef MIPS_REGISTER_BYTE -#define MIPS_REGISTER_BYTE(N) \ - (((N) < FP0_REGNUM) ? (N) * mips_regsize (current_gdbarch) : \ - ((N) < FP0_REGNUM + 32) ? \ - FP0_REGNUM * mips_regsize (current_gdbarch) + \ - ((N) - FP0_REGNUM) * sizeof(double) : \ - 32 * sizeof(double) + ((N) - 32) * mips_regsize (current_gdbarch)) - -#endif /* N32 */ - - /* The signal handler trampoline is called _sigtramp. */ #undef IN_SIGTRAMP #define IN_SIGTRAMP(pc, name) ((name) && STREQ ("_sigtramp", name)) Index: config/mips/tm-irix6.h =================================================================== RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v retrieving revision 1.18 diff -u -r1.18 tm-irix6.h --- config/mips/tm-irix6.h 16 Nov 2003 05:57:09 -0000 1.18 +++ config/mips/tm-irix6.h 16 Nov 2003 14:22:59 -0000 @@ -61,15 +61,6 @@ #define FCRCS_REGNUM 69 /* FP control/status */ #define FCRIR_REGNUM 70 /* FP implementation/revision */ - -#undef MIPS_REGISTER_BYTE -#define MIPS_REGISTER_BYTE(N) \ - (((N) < FP0_REGNUM) ? (N) * mips_regsize (current_gdbarch) : \ - ((N) < FP0_REGNUM + 32) ? \ - FP0_REGNUM * mips_regsize (current_gdbarch) + \ - ((N) - FP0_REGNUM) * sizeof(double) : \ - 32 * sizeof(double) + ((N) - 32) * mips_regsize (current_gdbarch)) - /* The signal handler trampoline is called _sigtramp. */ #undef IN_SIGTRAMP #define IN_SIGTRAMP(pc, name) ((name) && STREQ ("_sigtramp", name)) Index: config/mips/tm-mips.h =================================================================== RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v retrieving revision 1.55 diff -u -r1.55 tm-mips.h --- config/mips/tm-mips.h 16 Nov 2003 04:57:25 -0000 1.55 +++ config/mips/tm-mips.h 16 Nov 2003 14:22:59 -0000 @@ -89,11 +89,6 @@ #define PRID_REGNUM 89 /* Processor ID */ #define LAST_EMBED_REGNUM 89 /* Last one */ -/* Index within `registers' of the first byte of the space for - register N. */ - -#define MIPS_REGISTER_BYTE(N) ((N) * mips_regsize (current_gdbarch)) - /* Special symbol found in blocks associated with routines. We can hang mips_extra_func_info_t's off of this. */ --------------060708050401040300050601--