From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2135 invoked by alias); 14 Nov 2003 21:19:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2128 invoked from network); 14 Nov 2003 21:19:08 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 14 Nov 2003 21:19:08 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id E6FEF800046; Fri, 14 Nov 2003 16:19:07 -0500 (EST) Message-ID: <3FB546CB.80901@redhat.com> Date: Fri, 14 Nov 2003 21:19:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: libunwind basic support References: <3F8DBC4C.1080304@redhat.com> <3F8EFD49.3060502@redhat.com> <3F8F0FBC.8070809@redhat.com> <3F9714E8.1020406@redhat.com> <3FB16C3D.8070607@redhat.com> <3FB40EC4.4000406@redhat.com> <3FB41C64.10603@redhat.com> In-Reply-To: <3FB41C64.10603@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00310.txt.bz2 Patch checked in. I forgot acconfig.h in the original patch which just added the #undef HAVE_LIBUNWIND reference. The following is the amended ChangeLog entry. 2003-11-14 Jeff Johnston * libunwind-frame.c: New file. * libunwind-frame.h: New file. * acconfig.h (HAVE_LIBUNWIND): #undef reference added. * configure.in: Add --with-libunwind option support. Define HAVE_LIBUNWIND if libunwind support selected / defaulted. Also check for libunwind.h and libunwind-ia64.h headers. * configure: Regenerated. * Makefile.in: Add support for libunwind-frame.o. * config.in: Regenerated. Thanks, -- Jeff J. Andrew Cagney wrote: > >> It is possible for the user to enable libunwind but the header files >> are not there. I am guessing you would prefer compilation to fail in >> this case so I have removed the check. > > > Yes. If the user forces the use of libunwind, but it isn't there, the > user should loose. > >> I have added comments for the search unwind table call. > > > Thanks. > > >> Index: configure.in >> =================================================================== >> RCS file: /cvs/src/src/gdb/configure.in,v >> retrieving revision 1.132 >> diff -u -r1.132 configure.in >> --- configure.in 3 Sep 2003 15:02:48 -0000 1.132 >> +++ configure.in 22 Oct 2003 23:36:21 -0000 >> @@ -192,6 +192,33 @@ >> enable_gdbtk=no ;; >> esac >> >> >> Based on 12.1 Working With External Software >> http://www.gnu.org/software/autoconf/manual/autoconf-2.57/html_chapter/autoconf_12.html#SEC130 >> >> >> I suspect that this should be --with (external libunwind software), >> and not --enable (gdb feature), although, to be honest, its hard to >> tell which it should be. >> >> Anyone? >> >> >> From discussions with Jeff Law when I was doing configuration for >> newlib, he told me that --enable should be used for on/off decisions >> in preference to --with. I don't personally care so I have switched >> to --with. > > > Thanks. > > You're right that the lines are blured. enable/disable is for > controlling the presence of an internal feature while with/without is > for controlling a dependency/use of an external program, or library. > Unfortunatly, here the decision to build GDB with/without the external > libunwind library has the consequence of determining if GDB should > enable/disable the internal (but not user visible) libunwind unwinder. I > think, based on the presence of X as an example in the manual, the > with/without takes precidence. > > So, yes all ok. > Andrew > > > >> Index: libunwind-frame.c > > > >