From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21968 invoked by alias); 10 Nov 2003 16:19:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21961 invoked from network); 10 Nov 2003 16:19:07 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 10 Nov 2003 16:19:07 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6B61B2B8F; Mon, 10 Nov 2003 11:19:05 -0500 (EST) Message-ID: <3FAFBA79.9060102@redhat.com> Date: Mon, 10 Nov 2003 16:19:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] New function gdbarch_infi_fill References: <3FAED2DE.5000904@gnu.org> <20031110004823.GA7416@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------010609020908030003060902" X-SW-Source: 2003-11/txt/msg00190.txt.bz2 This is a multi-part message in MIME format. --------------010609020908030003060902 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 728 > On Sun, Nov 09, 2003 at 06:50:54PM -0500, Andrew Cagney wrote: > >> Hello, >> >> The attached adds the new function gdbarch_info_fill. This new function >> fills in un-initialized fields of the "info" structure using global >> "set" variables and the "gdbarch" parameter. >> >> committed, >> Andrew > > > Yeah! I've wanted this before. Though now I can't remember why. This all begs two questions. Should gdbarch_info be filled in first? Should the assertion: gdbarch_find_by_info (gdbarch_info (gdbarch)) == gdbarch always hold? At present architectures like the MIPS make this very hard - keying off information found in the BFD and not the corresponding info struct. > "Similar to". Fixed. Andrew --------------010609020908030003060902 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1424 2003-11-10 Andrew Cagney * arch-utils.h, arch-utils.c: Fix typo in comment. Index: arch-utils.c =================================================================== RCS file: /cvs/src/src/gdb/arch-utils.c,v retrieving revision 1.105 diff -u -r1.105 arch-utils.c --- arch-utils.c 10 Nov 2003 16:03:26 -0000 1.105 +++ arch-utils.c 10 Nov 2003 16:16:22 -0000 @@ -686,7 +686,7 @@ info->osabi = GDB_OSABI_UNINITIALIZED; } -/* Similar it init, but this time fill in the blanks. Information is +/* Similar to init, but this time fill in the blanks. Information is obtained from the specified architecture, global "set ..." options, and explicitly initialized INFO fields. */ Index: arch-utils.h =================================================================== RCS file: /cvs/src/src/gdb/arch-utils.h,v retrieving revision 1.61 diff -u -r1.61 arch-utils.h --- arch-utils.h 9 Nov 2003 23:52:28 -0000 1.61 +++ arch-utils.h 10 Nov 2003 16:16:22 -0000 @@ -153,7 +153,7 @@ default values are not zero. */ extern void gdbarch_info_init (struct gdbarch_info *info); -/* Similar it init, but this time fill in the blanks. Information is +/* Similar to init, but this time fill in the blanks. Information is obtained from the specified architecture, global "set ..." options, and explicitly initialized INFO fields. */ extern void gdbarch_info_fill (struct gdbarch *gdbarch, --------------010609020908030003060902--