From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31215 invoked by alias); 9 Nov 2003 13:54:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31206 invoked from network); 9 Nov 2003 13:54:22 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.0.121) by sources.redhat.com with SMTP; 9 Nov 2003 13:54:22 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9E38A2B8F; Sun, 9 Nov 2003 08:54:19 -0500 (EST) Message-ID: <3FAE470B.6050607@gnu.org> Date: Sun, 09 Nov 2003 13:54:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] SYMBOL_LOCATION_FUNCS -> SYMBOL_OPS References: <3FAD53AD.4030003@gnu.org> <20031108213118.GA29731@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00166.txt.bz2 > FWIW, this patch looks good to me. I only have two questions. One is > with the generalized name - do you expect anything besides the location > (the aclass really is a part of the location, I think) to be handled by > these ops? I'm not sure what else there is, so it's just an idle > thought. Other methods that play with the union come to mind. > And, I think I see where you're going with the index idea, but since it > wasn't obvious until the second time through: the index could take up > to ten bits, replacing the address class, and thereby eliminating the > ops pointer. That's where the 32 bits comes from, not from eliminating > aclass. This costs a table lookup every time you want to get at the > aclass or ops, but that's probably OK. Yes. Doing a location extraction isn't on a hot path. Andrew