From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22882 invoked by alias); 7 Nov 2003 21:25:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22874 invoked from network); 7 Nov 2003 21:25:29 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 7 Nov 2003 21:25:29 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B69832B8F; Fri, 7 Nov 2003 16:25:29 -0500 (EST) Message-ID: <3FAC0DC9.6010609@redhat.com> Date: Fri, 07 Nov 2003 21:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] deprecate inside_entry_func References: <3FA2F940.5040102@redhat.com> <1031101003654.ZM5020@localhost.localdomain> <3FA30271.5020908@redhat.com> <1031101005517.ZM5150@localhost.localdomain> <3FA31A0F.5060706@gnu.org> <1031107173135.ZM17860@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00134.txt.bz2 > Then I'm puzzled as to why you are objecting to me deprecating this >> existing garish hack? Remember, I also wrote: >> >> > + /* NOTE: cagney/2003-10-31: A very simple test, such as >> > + get_frame_func == entry_point should be sufficient for >> > + identifying a pc in the entry function. Does anyone know why it >> > + wasn't sufficient and hence, why the very convoluted >> > + "deprecated_inside_entry_func" is needed. */ > > > What I'm suggesting is that you implement inside_entry_func() using > "get_frame_func == entry_point". What's so garish about that? That task is best left to the person with a direct requirement for the mechanism. That way, at the time the new code is committed, it has both a clear need and is known to work. This is of course separate to deprecating inside_entry_func's current implementation. The reason for deprecated the old code is to make its status very clear - don't use it in new code and try to eliminate it from old code. enjoy, Andrew