From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16598 invoked by alias); 7 Nov 2003 19:12:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16585 invoked from network); 7 Nov 2003 19:12:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 Nov 2003 19:12:40 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA7JCdM21431 for ; Fri, 7 Nov 2003 14:12:39 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA7JCca24092; Fri, 7 Nov 2003 14:12:38 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id hA7JCbJ14154; Fri, 7 Nov 2003 11:12:37 -0800 Message-ID: <3FABEEA5.4080900@redhat.com> Date: Fri, 07 Nov 2003 19:12:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner CC: Dave Brolley , gdb-patches@sources.redhat.com Subject: Re: [RFA] FR-V SIM: Check availability of GR and FR regs References: <1031107063317.ZM15719@localhost.localdomain> <3FABD6AC.5000806@redhat.com> <1031107174924.ZM17946@localhost.localdomain> In-Reply-To: <1031107174924.ZM17946@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00123.txt.bz2 Kevin Buettner wrote: > On Nov 7, 12:30pm, Dave Brolley wrote: > > >>I'm not sure if it's ok to include gdb/sim-frv.h from within the >>simulator code. I thought the interface went the other way around (i.e. >>gdb includes sim/frv-sim.h). > > > Keep in mind that gdb/sim-frv.h is actually include/gdb/sim-frv.h. > This file contains only those register numbers which are needed for > sim <-> gdb interactions. The file sim/frv-sim.h contains quite a lot > more. I'd be more than a little nervous including it in gdb's > frv-tdep.c. > > Before embarking on this course, I did check for precedents. Here's > what I found: > > sim/sh64/sh64.c[34]: #include "gdb/sim-sh.h" > sim/sh/interp.c[32]: #include "gdb/sim-sh.h" > sim/h8sx/compile.c[33]: #include "gdb/sim-h8300.h" > sim/h8300/compile.c[33]: #include "gdb/sim-h8300.h" > sim/d10v/interp.c[8]: #include "gdb/sim-d10v.h" > sim/arm/wrapper.c[39]: #include "gdb/sim-arm.h" > > >>Other than that, it looks ok to me. > > > I'll wait until we've resolved the above to commit it. Yo -- this is exactly what include/gdb is for. That's where you put the interface that gdb has to share with (for instance) the sim. So yes -- it sounds like that is where you want to put your shared header file. Michael