From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12743 invoked by alias); 6 Nov 2003 22:47:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12733 invoked from network); 6 Nov 2003 22:47:09 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 6 Nov 2003 22:47:09 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 6C6A7800046; Thu, 6 Nov 2003 17:47:09 -0500 (EST) Message-ID: <3FAACF6D.8080109@redhat.com> Date: Thu, 06 Nov 2003 22:47:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: Daniel Jacobowitz , Kevin Buettner , Marcel Moolenaar , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Add child_to_xfer_partial; Was: ia64 portion of libunwind patch References: <3F986E31.8050201@redhat.com> <1031024175718.ZM3475@localhost.localdomain> <3F996D88.9060505@redhat.com> <1031024185625.ZM9827@localhost.localdomain> <3F9F0180.2010702@redhat.com> <20031029012833.GA11070@nevyn.them.org> <3FA043B2.6090401@redhat.com> <3FA7F97B.4090909@redhat.com> <3FAACBE3.3060104@redhat.com> In-Reply-To: <3FAACBE3.3060104@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00108.txt.bz2 Andrew Cagney wrote: > Jeff, > > This adds a child_xfer_partial method to "inftarg.c". I've included a > hook vis: > >> +#if 0 >> + case TARGET_OBJECT_UNWIND_TABLE: >> +#ifndef NATIVE_XFER_UNWIND_TABLE >> +#define >> NATIVE_XFER_UNWIND_TABLE(OPS,OBJECT,ANNEX,WRITEBUF,READBUF,OFFSET,LEN) >> (-1) >> +#endif >> + return NATIVE_XFER_UNWIND_TABLE (ops, object, annex, writebuf, >> + readbuf, offset, len); >> +#endif > > > so that, in theory, all you need do is define that in the linux specific > nm-*.h file. > > I think this will make plugging in additional xfer methods easier. How > does it look? > I like it because it means I only have to provide the particular functionality instead of overriding the whole function which could be dangerous if other changes were made to the default_xfer_partial routine. > Anyone else? > Andrew > > PS: You'll notice that it also contains lurking code to add support for > an auxv transfer. > > PPS: Note that I need to better test it.