From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25193 invoked by alias); 1 Nov 2003 02:37:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25182 invoked from network); 1 Nov 2003 02:37:28 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.0.121) by sources.redhat.com with SMTP; 1 Nov 2003 02:37:28 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id EFF012B89; Fri, 31 Oct 2003 21:37:24 -0500 (EST) Message-ID: <3FA31C64.9060306@gnu.org> Date: Sat, 01 Nov 2003 02:37:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] deprecate inside_entry_func References: <3FA2F940.5040102@redhat.com> <20031101004233.GA11987@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00011.txt.bz2 > On Fri, Oct 31, 2003 at 07:07:28PM -0500, Andrew Cagney wrote: > >> Hello, >> >> This patch deprecates the function inside_entry_func. Per the new comments: >> >> + /* NOTE: cagney/2003-10-31: A very simple test, such as >> + get_frame_func == entry_point should be sufficient for >> + identifying a pc in the entry function. Does anyone know why it >> + wasn't sufficient and hence, why the very convoluted >> + "deprecated_inside_entry_func" is needed. */ >> + /* NOTE: cagney/2003-10-31: An ABI and its crt0 code should define >> + and implement a clean frame termination. Not doing that is >> + really a bug in the ABI/crt0, and, hence, not a reason for >> + enabling the call to deprecated_inside_entry_func. */ > > > If handling broken systems isn't the job of GDB, then I surely don't > know what is. > Do you have a reason for wanting to deprecate this function? Per my first new comment: /* NOTE: cagney/2003-10-31: A very simple test, such as get_frame_func == entry_point should be sufficient for identifying a pc in the entry function. Does anyone know why it wasn't sufficient and hence, why the very convoluted "deprecated_inside_entry_func" is needed. */ and the previous comment: /* NOTE: cagney/2003-02-25: Don't enable until someone has found hard evidence that this is needed. */ There is _still_ no evidence that this disabled hack is needed - time to deprecate it. Andrew