From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22821 invoked by alias); 1 Nov 2003 02:27:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22809 invoked from network); 1 Nov 2003 02:27:47 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.0.121) by sources.redhat.com with SMTP; 1 Nov 2003 02:27:47 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 092F22B89; Fri, 31 Oct 2003 21:27:28 -0500 (EST) Message-ID: <3FA31A0F.5060706@gnu.org> Date: Sat, 01 Nov 2003 02:27:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] deprecate inside_entry_func References: <3FA2F940.5040102@redhat.com> <1031101003654.ZM5020@localhost.localdomain> <3FA30271.5020908@redhat.com> <1031101005517.ZM5150@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00010.txt.bz2 > Kevin, you previously wrote: >> > >> >> I'd like to avoid re-introducing a dependency on inside_entry_func() as >> >> that places garish requirements on the object file readers :-( > >> > >> > I agree that object file readers should not attempt to track of >> > the bounds of the start function. However, given an arbitrary >> > address, it's not unreasonable to ask the symtab machinery to attempt >> > to figure out the function bounds. And, in fact, this is just what >> > find_pc_partial_function() does. > > > Yes, the reason I wrote this was to note that there are other ways of > implementing inside_entry_func() which wouldn't place garish > requirements on the object file readers. Then I'm puzzled as to why you are objecting to me deprecating this existing garish hack? Remember, I also wrote: > + /* NOTE: cagney/2003-10-31: A very simple test, such as > + get_frame_func == entry_point should be sufficient for > + identifying a pc in the entry function. Does anyone know why it > + wasn't sufficient and hence, why the very convoluted > + "deprecated_inside_entry_func" is needed. */ Andrew