From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32000 invoked by alias); 31 Oct 2003 16:13:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31971 invoked from network); 31 Oct 2003 16:12:59 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 31 Oct 2003 16:12:59 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C27512B89; Fri, 31 Oct 2003 11:12:57 -0500 (EST) Message-ID: <3FA28A09.7060306@redhat.com> Date: Fri, 31 Oct 2003 16:13:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] to_read/write_partial -> to_xfer_partial References: <3F9D7F21.6030001@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00874.txt.bz2 > Hello, > > Per: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00641.html > Having taken the change to this point, I'm now wondering if the read/write partial methods should be merged into: > to_xfer_partial (targ, object, annex, > offset, len, > readbuf, writebuf) > as that would make migrating existing targets easier. > > Having implemented bfd-target and remote-target versions to_read/write_partial, I think this switch is going to make life easier. The attached converts the code. > > Comments? > > I'll also update the bfd-target I've posted. I've checked this in. Andrew > 2003-10-27 Andrew Cagney > > * target.h (struct target_ops): Replace "to_read_partial" and > "to_write_partial" with "to_xfer_partial". Update comments. > * target.c (debug_to_write_partial): Delete function. > (debug_to_xfer_partial): Replace debug_to_read_partial. > (add_target, update_current_target, setup_target_debug): Set > "to_xfer_partial" instead of "to_read_partial" and > "to_write_partial". > (default_xfer_partial): Replace "default_write_partial". > (default_read_partial): Delete. > (target_read_partial, target_write_partial): Call > "to_xfer_partial". > * remote.c (init_remote_ops): Set "to_xfer_partial". > (init_remote_async_ops): Ditto. > (remote_xfer_partial): Replace "remote_read_partial". >