From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21393 invoked by alias); 28 Oct 2003 17:09:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21385 invoked from network); 28 Oct 2003 17:09:52 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 28 Oct 2003 17:09:52 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 6578580040C; Tue, 28 Oct 2003 12:09:51 -0500 (EST) Message-ID: <3F9EA2DF.7080605@redhat.com> Date: Tue, 28 Oct 2003 17:09:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com, jimb@redhat.com Subject: Re: RFA: switch to printf_unfiltered in symfile.c References: <3F96CF9A.9080003@redhat.com> <20031028043039.GA27446@nevyn.them.org> <16286.38008.938675.454310@localhost.redhat.com> In-Reply-To: <16286.38008.938675.454310@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00813.txt.bz2 Thanks. Patch committed to mainline. -- Jeff J. Elena Zannoni wrote: > Daniel Jacobowitz writes: > > On Wed, Oct 22, 2003 at 02:42:34PM -0400, J. Johnston wrote: > > > The following patch switches over the majority of the printfs in symfile.c > > > to use printf_unfiltered. This fixes a problem whereby if you attach to a > > > process that has a lot of dynamic library references, you will get page > > > breaks as it displays loading symbols messages. > > > > > > I purposely left printf_filtered for info_ext_lang_command(), and > > > list_overlays_command() as I felt that a user may want to examine the > > > output and this should allow paging if necessary. > > > > > > Ok to commit? > > > > > > -- Jeff J. > > > > > > 2003-10-22 Jeff Johnston > > > > > > * symfile.c (symbol_file_add_with_addrs_or_offsets): Switch to use > > > printf_unfiltered instead of printf_filtered for output messages. > > > (add_symbol_file_command): Ditto. > > > (reread_symbols): Ditto. > > > (overlay_auto_command): Ditto. > > > (overlay_manual_command): Ditto. > > > (overlay_off_command): Ditto. > > > > Do any of our symtab maintainers have a comment on this patch? I > > vaguely remember that you agreed with it on gdb@, Jim? > > > > I'll approve it. I did some digging in the old Cygnus repository that > dates back to 1991, and the code was already like that back then. So > there really seem to be no rationale other than letting the user read > the messages. Maybe back then nobody imagined that there would be more > than a screen of output. > > elena > > > > > > -- > > Daniel Jacobowitz > > MontaVista Software Debian GNU/Linux Developer >