From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7775 invoked by alias); 23 Oct 2003 02:55:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7768 invoked from network); 23 Oct 2003 02:55:27 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 23 Oct 2003 02:55:27 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 139492B89; Wed, 22 Oct 2003 22:55:26 -0400 (EDT) Message-ID: <3F97431D.3040500@redhat.com> Date: Thu, 23 Oct 2003 02:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] target_open (target, ...) References: <3F96F8E6.5000702@redhat.com> <20031023023607.GA2637@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00681.txt.bz2 > Wrong patch? This is target_close, not target_open. It also deletes > the target_open macro without adding a new target_open function. No, a 180 description. s/target_open/target_close/. The _macro_ target_open() is _never_ called. > Please don't add 'x'. There's nothing wrong with having a target_open > function which calls target_ops->to_open. The vector already contains ->to_open and ->to_close methods so unless we've switched to C++, I can't add a second to_close. Once the existing ->to_close is deprecated, I can rename ->to_xclose. Andrew