From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19584 invoked by alias); 22 Oct 2003 23:37:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19574 invoked from network); 22 Oct 2003 23:37:22 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 22 Oct 2003 23:37:22 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 969DC2B89 for ; Wed, 22 Oct 2003 19:37:21 -0400 (EDT) Message-ID: <3F9714B1.9040102@redhat.com> Date: Wed, 22 Oct 2003 23:37:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Add backward compat to target read/write partial References: <3F957173.7020106@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00666.txt.bz2 > Hello, > > The attached patch adds backward compatibility to the recently added read/write partial target vector methods. If a given target vector has to_xfer_memory but not to_read/write_partial, the to_xfer_memory method is used. > > It was implemented by adding default read/write partial methods to each target vector. > > For testing, I tweaked the existing read/write memory thus: > +#if 0 > return target_xfer_memory (memaddr, myaddr, len, 0); > +#else > + return (target_read (¤t_target, TARGET_OBJECT_MEMORY, > + NULL, myaddr, memaddr, len) > + <= 0); > +#endif > (included in the patch for reference, must remember to delete it ...). It turned up one bug. > > Comments? > > Having taken the change to this point, I'm now wondering if the read/write partial methods should be merged into: > to_xfer_partial (targ, object, annex, > offset, len, > readbuf, writebuf) > as that would make migrating existing targets easier. I'm just checking this in .... Andrew