From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20820 invoked by alias); 15 Oct 2003 22:39:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20813 invoked from network); 15 Oct 2003 22:39:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 15 Oct 2003 22:39:40 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9FMddM27906 for ; Wed, 15 Oct 2003 18:39:39 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9FMdKL28615; Wed, 15 Oct 2003 18:39:25 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h9FMdJJ09327; Wed, 15 Oct 2003 15:39:19 -0700 Message-ID: <3F8DCC97.7000603@redhat.com> Date: Wed, 15 Oct 2003 22:39:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney CC: Kevin Buettner , gdb-patches@sources.redhat.com Subject: Re: [PATCH] frv-tdep.c: Stop backtraces in entry func, not entry file References: <1031014205135.ZM29586@localhost.localdomain> <3F8C70CE.5020504@gnu.org> In-Reply-To: <3F8C70CE.5020504@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00520.txt.bz2 Andrew Cagney wrote: >> An FR-V user reported being unable to see useful backtraces when >> debugging functions inside the entry file. This patch fixes that >> problem. I think there's a problem with inside_entry_func() itself, >> but that's a separate issue. (If you are in the entry file, >> backtraces don't stop at the entry func - they attempt to continue >> beyond, but they do stop shortly thereafter.) > > > What happens if that test is removed? > > I believe the below test has its origins in a d10v hack to get around > what was then a broken back-trace-past-main problem. The problems been > fixed, but unfortunatly, the original hack keeps turning up. Checking for the entry file/function? Oh, it's older than that... >> Kevin >> >> * frv-tdep.c (frv_frame_this_id): Call inside_entry_func() >> instead of deprecated_inside_entry_file(). >> >> Index: frv-tdep.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/frv-tdep.c,v >> retrieving revision 1.54 >> diff -u -p -r1.54 frv-tdep.c >> --- frv-tdep.c 14 Oct 2003 00:30:27 -0000 1.54 >> +++ frv-tdep.c 14 Oct 2003 20:40:18 -0000 >> @@ -1009,7 +1009,7 @@ frv_frame_this_id (struct frame_info *ne >> >> /* This is meant to halt the backtrace at "_start". Make sure we >> don't halt it at a generic dummy frame. */ >> - if (deprecated_inside_entry_file (func)) >> + if (inside_entry_func (func)) >> return; >> >> /* Check if the stack is empty. */ >> > > >