Re: [patch/rfc] Simplify target stack

Daniel Jacobowitz
2003-10-16T13:16:14Z

On Wed, Oct 15, 2003 at 06:37:46PM -0400, Andrew Cagney wrote:
> Hello,
>
> The attached patch simplifies the target-stack by folding the "struct
> target_stack_item" into the "struct target_ops". The field "struct
> target_ops . beneath" being added.
>
> This in turn greatly simplifies the logic needed to walk the target
> stack (target_beneath becomes a one-liner), and that in turn lets me
> correctly implement the new target read/write partial methods I just posted.
>
> Note that this implementation is still limited to a single target stack
> (due to all the target_ops vectors being static). Follow-on changes can
> eliminate that restriction.
>
> Once I've finished testing, I'll look to commit it in a day or so,
> Andrew

You're moving beneath into target_ops, but aren't you going to have to
either move it out again or move everything else from target_ops? It
seems to me that we want the method vector to be constant eventually
(kill the INHERIT mess), but the target to have local data. Just seems
like this is happening in the wrong order. Another way would be:
- rename target_ops and target_item
- make access to target go through the renamed version of target_item
- add a target_data member to the renamed target_data

Other than that seems good.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer