From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11577 invoked by alias); 15 Oct 2003 16:47:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11551 invoked from network); 15 Oct 2003 16:47:20 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 15 Oct 2003 16:47:20 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2228A2B89; Wed, 15 Oct 2003 12:47:21 -0400 (EDT) Message-ID: <3F8D7A18.30409@redhat.com> Date: Wed, 15 Oct 2003 16:47:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni Cc: Michael Elizabeth Chastain , nickc@redhat.com, gdb-patches@sources.redhat.com, rearnsha@arm.com Subject: Re: [PATCH/RFC] coffread.c: delete param References: <200310151626.h9FGQKBZ021297@duracef.shout.net> <16269.31369.339106.180129@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00494.txt.bz2 > > The change from 4.17 to 4.18 added the new COFF_MAKE_MSYMBOL_SPECIAL, > > and changed arm-tdep.c to use the new COFF_MAKE_MSYMBOL_SPECIAL, > > but did not delete the old dangling c_sclass code. > > > > Someone with access to the old Cygnus CVS repository might be able > > to say more about the exact change some time between 4.17 and 4.18. > > Did you see my posting with the exact diffs (from 1998) I posted > yesterday? > http://sources.redhat.com/ml/gdb-patches/2003-10/msg00470.html > > That explains in detail what happened, which is pretty much how you > describe it here. BTW, if COFF's minimal symbol pointed at the bfd symbol, GDB could share the logic: > if (!is_thumb && info->symbols != NULL) > { > if (bfd_asymbol_flavour (*info->symbols) == bfd_target_coff_flavour) > { > coff_symbol_type * cs; > > cs = coffsymbol (*info->symbols); > is_thumb = ( cs->native->u.syment.n_sclass == C_THUMBEXT > || cs->native->u.syment.n_sclass == C_THUMBSTAT > || cs->native->u.syment.n_sclass == C_THUMBLABEL > || cs->native->u.syment.n_sclass == C_THUMBEXTFUNC > || cs->native->u.syment.n_sclass == C_THUMBSTATFUNC); > } > else if (bfd_asymbol_flavour (*info->symbols) == bfd_target_elf_flavour) > { > elf_symbol_type * es; > unsigned int type; > > es = *(elf_symbol_type **)(info->symbols); > type = ELF_ST_TYPE (es->internal_elf_sym.st_info); > > is_thumb = (type == STT_ARM_TFUNC) || (type == STT_ARM_16BIT); > } > } > found in opcodes/arm-dis.c with bfd/opcodes. Similar for MIPS, SH-5, M68HC11, ... Andrew