From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29915 invoked by alias); 15 Oct 2003 15:39:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29884 invoked from network); 15 Oct 2003 15:39:50 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 15 Oct 2003 15:39:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0E1C82B89; Wed, 15 Oct 2003 11:39:52 -0400 (EDT) Message-ID: <3F8D6A47.4090201@redhat.com> Date: Wed, 15 Oct 2003 15:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nick Clifton Cc: Elena Zannoni , gdb-patches@sources.redhat.com, rearnsha@arm.com Subject: Re: [PATCH/RFC] coffread.c: delete param References: <16268.28727.18741.65995@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00489.txt.bz2 > Given Andrew's comment in the code, I would be rather wary of this > patch. Presumably there is some good reason for passing the > cs->c_sclass field in the (void *) pointer argument slot, or otherwise > Andrew would not have gone to all that trouble of casting it. No. I went to the trouble of casing it so that it got past GCC -Werror. Andrew >> - >> - /* FIXME: cagney/2001-02-01: The nasty (int) -> (long) >> - -> (void*) cast is to ensure that that the value of >> - cs->c_sclass can be correctly stored in a void >> - pointer in MSYMBOL_INFO. Better solutions >> - welcome. */ >> - gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass)); >> msym = prim_record_minimal_symbol_and_info >> - (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass, >> + (cs->c_name, tmpaddr, ms_type, NULL, >> sec, NULL, objfile); > > > >> [Richard, Nick, this does affect arm-coff] > > > Does it improve things ? :-) If so, what ? > > Cheers > Nick > > >