From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21121 invoked by alias); 10 Oct 2003 02:40:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21110 invoked from network); 10 Oct 2003 02:39:59 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 10 Oct 2003 02:39:59 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 94DEC2B89; Thu, 9 Oct 2003 22:39:51 -0400 (EDT) Message-ID: <3F861BF7.3020708@redhat.com> Date: Fri, 10 Oct 2003 02:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner , Jimi Xenidis Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP References: <3F4398EC.2050405@redhat.com> <16195.39851.78762.619597@kitch0.watson.ibm.com> <3F4440F0.30007@redhat.com> <16198.6133.411978.563514@kitch0.watson.ibm.com> <3F463CA9.5000900@redhat.com> <16198.21410.308896.588372@kitch0.watson.ibm.com> <3F465EFD.9020700@redhat.com> <16220.53590.956496.102996@kitch0.watson.ibm.com> <20030908190016.GB24747@nevyn.them.org> <16220.58287.637563.556990@kitch0.watson.ibm.com> <20030908202005.GA30286@nevyn.them.org> <16220.62220.290008.652878@kitch0.watson.ibm.com> <1030908220107.ZM6208@localhost.localdomain> <16221.61979.434255.784317@kitch0.watson.ibm.com> <1030909161519.ZM20803@localhost.localdomain> <16222.1885.6189.269410@kitch0.watson.ibm.com> <1030909175522.ZM21202@localhost.localdomain> <16222.19873.6535.22360@kitch0.watson.ibm.com> <1030910012430.ZM3983@localhost.localdomain> Content-Type: multipart/mixed; boundary="------------050005020704090405020102" X-SW-Source: 2003-10/txt/msg00349.txt.bz2 This is a multi-part message in MIME format. --------------050005020704090405020102 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 858 > On Sep 9, 6:01pm, Jimi Xenidis wrote: > > >> diff -Naur -X Xdiff src/gdb/ChangeLog mygdb/gdb/ChangeLog >> --- src/gdb/ChangeLog Tue Sep 9 17:33:08 2003 >> +++ mygdb/gdb/ChangeLog Tue Sep 9 17:03:52 2003 >> @@ -1,3 +1,14 @@ >> +2003-09-09 Jimi Xenidis >> + >> + * config/powerpc/tm-ppc-eabi.h: no longer require custion #define of >> + SOFTWARE_SINGLE_STEP >> + * config/rs6000/tm-rs6000.h: no longer require custion #define of >> + SOFTWARE_SINGLE_STEP >> + * config/powerpc/tm-linux.h: no longer require custion #define of >> + SOFTWARE_SINGLE_STEP >> + * rs6000-tdep.c (rs6000_gdbarch_init): Set up software_single_step >> + while initing gdbarch > > > This is okay so long as the nits we discussed privately -- ChangeLog entry > formatting and comment wording -- are fixed. FYI, I've checked this in for Jimi. Andrew --------------050005020704090405020102 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 3493 2003-10-09 Andrew Cagney Changes from 2003-09-09 Jimi Xenidis : * config/rs6000/tm-rs6000.h (SOFTWARE_SINGLE_STEP): Delete macro. (SOFTWARE_SINGLE_STEP_P): Ditto. * config/powerpc/tm-ppc-eabi.h (SOFTWARE_SINGLE_STEP_P): Ditto. * config/powerpc/tm-linux.h (SOFTWARE_SINGLE_STEP): Ditto. (SOFTWARE_SINGLE_STEP_P): Ditto. * rs6000-tdep.c (rs6000_gdbarch_init): When AIX, set software_single_step to rs6000_software_single_step. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.166 diff -u -r1.166 rs6000-tdep.c --- rs6000-tdep.c 3 Oct 2003 21:11:39 -0000 1.166 +++ rs6000-tdep.c 10 Oct 2003 02:35:14 -0000 @@ -3008,6 +3008,16 @@ /* Hook in ABI-specific overrides, if they have been registered. */ gdbarch_init_osabi (info, gdbarch); + if (from_xcoff_exec) + { + /* NOTE: jimix/2003-06-09: This test should really check for + GDB_OSABI_AIX when that is defined and becomes + available. (Actually, once things are properly split apart, + the test goes away.) */ + /* RS6000/AIX does not support PT_STEP. Has to be simulated. */ + set_gdbarch_software_single_step (gdbarch, rs6000_software_single_step); + } + return gdbarch; } Index: config/powerpc/tm-linux.h =================================================================== RCS file: /cvs/src/src/gdb/config/powerpc/tm-linux.h,v retrieving revision 1.14 diff -u -r1.14 tm-linux.h --- config/powerpc/tm-linux.h 3 Sep 2003 21:01:44 -0000 1.14 +++ config/powerpc/tm-linux.h 10 Oct 2003 02:35:14 -0000 @@ -31,12 +31,6 @@ #undef IN_SOLIB_CALL_TRAMPOLINE #undef SKIP_TRAMPOLINE_CODE -/* We can single step on linux */ -#undef SOFTWARE_SINGLE_STEP -#define SOFTWARE_SINGLE_STEP(p,q) internal_error (__FILE__, __LINE__, "Will never execute!") -#undef SOFTWARE_SINGLE_STEP_P -#define SOFTWARE_SINGLE_STEP_P() 0 - /* Make sure nexti gets the help it needs for debugging assembly code without symbols */ Index: config/powerpc/tm-ppc-eabi.h =================================================================== RCS file: /cvs/src/src/gdb/config/powerpc/tm-ppc-eabi.h,v retrieving revision 1.10 diff -u -r1.10 tm-ppc-eabi.h --- config/powerpc/tm-ppc-eabi.h 12 Apr 2002 19:48:37 -0000 1.10 +++ config/powerpc/tm-ppc-eabi.h 10 Oct 2003 02:35:14 -0000 @@ -24,9 +24,6 @@ /* Use generic RS6000 definitions. */ #include "rs6000/tm-rs6000.h" -/* except we want to allow single stepping */ -#undef SOFTWARE_SINGLE_STEP_P -#define SOFTWARE_SINGLE_STEP_P() 0 #undef PROCESS_LINENUMBER_HOOK Index: config/rs6000/tm-rs6000.h =================================================================== RCS file: /cvs/src/src/gdb/config/rs6000/tm-rs6000.h,v retrieving revision 1.27 diff -u -r1.27 tm-rs6000.h --- config/rs6000/tm-rs6000.h 22 Sep 2003 17:45:02 -0000 1.27 +++ config/rs6000/tm-rs6000.h 10 Oct 2003 02:35:14 -0000 @@ -84,12 +84,6 @@ (fromleaf ? DEPRECATED_SAVED_PC_AFTER_CALL (prev->next) : \ prev->next ? DEPRECATED_FRAME_SAVED_PC (prev->next) : read_pc ()) -/* RS6000/AIX does not support PT_STEP. Has to be simulated. */ - -#define SOFTWARE_SINGLE_STEP_P() 1 -extern void rs6000_software_single_step (enum target_signal, int); -#define SOFTWARE_SINGLE_STEP(sig,bp_p) rs6000_software_single_step (sig, bp_p) - /* Notice when a new child process is started. */ #define TARGET_CREATE_INFERIOR_HOOK rs6000_create_inferior --------------050005020704090405020102--