From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16351 invoked by alias); 10 Oct 2003 00:15:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16336 invoked from network); 10 Oct 2003 00:15:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Oct 2003 00:15:01 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9A0F0M06439 for ; Thu, 9 Oct 2003 20:15:00 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9A0ExD07735; Thu, 9 Oct 2003 20:14:59 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h9A0Ewi14006; Thu, 9 Oct 2003 17:14:58 -0700 Message-ID: <3F85FA02.7020906@redhat.com> Date: Fri, 10 Oct 2003 00:15:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] sh-tdep.c: delete unneeded function. References: <16261.46068.56352.920472@localhost.redhat.com> In-Reply-To: <16261.46068.56352.920472@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00337.txt.bz2 Elena Zannoni wrote: > This function is not used for sh, because it is only called for > targets that have the call dummy location set as ON_STACK. SH uses > AT_ENTRY_POINT. > > elena > > > 2003-10-09 Elena Zannoni > > * sh-tdep.c (sh_gdbarch_init): Delete setting of push_dummy_code. > (sh_gdbarch_init): Delete function, it's only used for dummy calls Shouldn't that last be (sh_push_dummy_code):? > on stack. > > Index: sh-tdep.c > =================================================================== > RCS file: /cvs/uberbaum/gdb/sh-tdep.c,v > retrieving revision 1.145 > diff -u -p -r1.145 sh-tdep.c > --- sh-tdep.c 3 Oct 2003 08:13:37 -0000 1.145 > +++ sh-tdep.c 9 Oct 2003 17:36:22 -0000 > @@ -266,22 +266,6 @@ sh_breakpoint_from_pc (CORE_ADDR *pcptr, > return breakpoint; > } > > -static CORE_ADDR > -sh_push_dummy_code (struct gdbarch *gdbarch, > - CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc, > - struct value **args, int nargs, > - struct type *value_type, > - CORE_ADDR *real_pc, CORE_ADDR *bp_addr) > -{ > - /* Allocate space sufficient for a breakpoint. */ > - sp = (sp - 2) & ~1; > - /* Store the address of that breakpoint */ > - *bp_addr = sp; > - /* sh always starts the call at the callee's entry point. */ > - *real_pc = funaddr; > - return sp; > -} > - > /* Prologue looks like > mov.l r14,@-r15 > sts.l pr,@-r15 > @@ -2032,7 +2016,6 @@ sh_gdbarch_init (struct gdbarch_info inf > set_gdbarch_decr_pc_after_break (gdbarch, 0); > set_gdbarch_function_start_offset (gdbarch, 0); > > - set_gdbarch_push_dummy_code (gdbarch, sh_push_dummy_code); > set_gdbarch_push_dummy_call (gdbarch, sh_push_dummy_call_nofpu); > > set_gdbarch_frame_args_skip (gdbarch, 0); >