From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9163 invoked by alias); 9 Oct 2003 19:41:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9150 invoked from network); 9 Oct 2003 19:41:19 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Oct 2003 19:41:19 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h99JfIM15677 for ; Thu, 9 Oct 2003 15:41:18 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h99JfHD24418; Thu, 9 Oct 2003 15:41:17 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h99JfGi32498; Thu, 9 Oct 2003 12:41:16 -0700 Message-ID: <3F85B9DC.4020804@redhat.com> Date: Thu, 09 Oct 2003 19:41:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] New threads test References: <20030930192158.GA5615@nevyn.them.org> <3F7B1ED7.4040403@redhat.com> <20031001185230.GA25467@nevyn.them.org> <20031009141057.GB29621@nevyn.them.org> In-Reply-To: <20031009141057.GB29621@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00309.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Oct 01, 2003 at 02:52:30PM -0400, Daniel Jacobowitz wrote: > >>On Wed, Oct 01, 2003 at 11:37:11AM -0700, Michael Snyder wrote: >> >>>Daniel Jacobowitz wrote: >>> >>>>This is a test for the remote protocol issue I'm solving with vCont. It >>>>also shows up in schedlock, but the simpler test makes it much clearer >>>>what's going wrong. OK? >>>> >>> >>>Umm... what is going wrong? What are you testing for here? >> >>+# It tests that the correct thread is single-stepped. >> >>More intelligibly: when gdbserver is told to single-step one thread >>(without holding all others schedlocked), it assumes we mean the first >>thread. Which might not be the _right_ thread. Hmmm... it should assume we mean the _current_ thread (ie. the one that had a stop event). The remote protocol should cover this (and did, last I checked). > Hi Michael, > > Is this test OK (with a better comment and the copyright notice that > Michael C suggested)? OK, with emphasis on "more comments".