From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1203 invoked by alias); 7 Oct 2003 04:17:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1195 invoked from network); 7 Oct 2003 04:17:02 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 7 Oct 2003 04:17:02 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 222772B89; Tue, 7 Oct 2003 00:17:00 -0400 (EDT) Message-ID: <3F823E3B.4070005@redhat.com> Date: Tue, 07 Oct 2003 04:17:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: unwind support for Linux 2.6 vsyscall DSO References: <200310070013.h970Ddai032605@magilla.sf.frob.com> <3F8238B0.50409@redhat.com> <20031007040754.GA32257@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00160.txt.bz2 > So I can see either an iterator, or an update to to_query being added to >> the target vector. Given that the iterator is a given, that might be >> the safest starting point - let the target maintainer go through and >> clean up to_query. > > > While I won't argue about an iterator being useful, I think that the > target vector code would be clearer if we just had the raw buffer. > Layer the iterator on top of it, instead of re-implementing the > iterator in every target. Each target won't implement the iterator. Rather it will call on a generic unpack method, and have that it do it. Andrew