From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com,
peter.schauer@regent.e-technik.tu-muenchen.de
Subject: Re: [rfa/6.0] fix aix inferior calls
Date: Tue, 30 Sep 2003 21:13:00 -0000 [thread overview]
Message-ID: <3F79F1EB.1020902@redhat.com> (raw)
In-Reply-To: <1030930003126.ZM16691@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
> On Sep 29, 4:33pm, Andrew Cagney wrote:
>
>
>> * rs6000-tdep.c (rs6000_gdbarch_init): Set the PowerOpen red zone
>> to 224, not 220.
>
>
> Okay, so long as you incorporate Andreas' suggested comment fix.
This is what was committed.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1162 bytes --]
2003-09-29 Andrew Cagney <cagney@redhat.com>
* rs6000-tdep.c (rs6000_gdbarch_init): Set the PowerOpen red zone
to 224, not 220.
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.145.2.2
diff -u -r1.145.2.2 rs6000-tdep.c
--- rs6000-tdep.c 18 Aug 2003 20:12:31 -0000 1.145.2.2
+++ rs6000-tdep.c 30 Sep 2003 21:09:02 -0000
@@ -2948,8 +2948,11 @@
/* PPC64 SYSV. */
set_gdbarch_frame_red_zone_size (gdbarch, 288);
else if (!sysv_abi && wordsize == 4)
- /* PowerOpen / AIX 32 bit. */
- set_gdbarch_frame_red_zone_size (gdbarch, 220);
+ /* PowerOpen / AIX 32 bit. The saved area or red zone consists of
+ 19 4 byte GPRS + 18 8 byte FPRs giving a total of 220 bytes.
+ Problem is, 220 isn't frame (16 byte) aligned. Round it up to
+ 224. */
+ set_gdbarch_frame_red_zone_size (gdbarch, 224);
set_gdbarch_deprecated_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
set_gdbarch_deprecated_push_return_address (gdbarch, ppc_push_return_address);
set_gdbarch_believe_pcc_promotion (gdbarch, 1);
prev parent reply other threads:[~2003-09-30 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 20:05 Andrew Cagney
2003-09-29 20:22 ` Kevin Buettner
2003-09-29 20:33 ` Andrew Cagney
2003-09-29 20:55 ` Andreas Schwab
2003-09-30 0:31 ` Kevin Buettner
2003-09-30 21:13 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F79F1EB.1020902@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
--cc=peter.schauer@regent.e-technik.tu-muenchen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox