> On Mon, Sep 15, 2003 at 04:54:17PM -0400, Andrew Cagney wrote: > >> >+/* Return non-zero iff the data at FROM is a valid number in format FMT. >> >*/ >> >+ >> >+int >> >+floatformat_is_valid (fmt, from) >> >+ const struct floatformat *fmt; >> >+ char *from; >> >+{ > >> >> Shouldn't this be a new virtual method in floatformat? The attached implements this. Any objections? > Floatformats don't have any virtual methods right now; if you want to > add them, be my guest. Besides, this is more in line with the > libiberty policy of backwards compatibility, since it does not change > the structure layout. There didn't seem to be a problem when "name" was added, or arm_ext was deleted. enjoy, Andrew