From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20110 invoked by alias); 12 Sep 2003 18:33:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20101 invoked from network); 12 Sep 2003 18:33:08 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 12 Sep 2003 18:33:08 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2848E2B89; Fri, 12 Sep 2003 14:33:04 -0400 (EDT) Message-ID: <3F62115F.5060302@redhat.com> Date: Fri, 12 Sep 2003 18:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:ppc] Cleanup SVR4 push dummy call References: <3F61DC59.5040706@redhat.com> <3F61DFB3.7000706@redhat.com> <1030912175624.ZM29278@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00266.txt.bz2 > On Sep 12, 11:01am, Andrew Cagney wrote: > > >> * ppc-sysv-tdep.c (align_up, align_down): Replace "round2" macro. >> (ppc_sysv_abi_push_dummy_call): Rewrite, use a two pass loop. > > > Okay, except... > > >> ! else if (len == 8 >> ! && (TYPE_CODE (type) == TYPE_CODE_INT /* long long */ >> ! || (!ppc_floating_point_unit_p (current_gdbarch) >> ! && TYPE_CODE (type) == TYPE_CODE_FLT))) /* double */ >> ! { >> ! /* "long long" or "double" passed in an odd/even >> ! register pair with the low addressed word in the odd >> ! register and the high addressed word in the even >> ! register, or when the registers run out an 8 byte >> ! aligned stack location. */ >> ! if (greg > 9) >> ! { >> ! /* Just in case GREG was 10. */ >> ! greg = 11; >> ! argoffset = align_up (argoffset, 8); >> ! write_memory (sp + argoffset, val, len); > > > ...I believe you forgot the ``if (write_pass)'' check on the above > call to write_memory(). Outch, yes. Good catch. Committed with fix. Andrew