From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18869 invoked by alias); 9 Sep 2003 22:59:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18862 invoked from network); 9 Sep 2003 22:59:54 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 9 Sep 2003 22:59:54 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 04CAE2B7F; Tue, 9 Sep 2003 18:59:53 -0400 (EDT) Message-ID: <3F5E5B68.5020902@redhat.com> Date: Tue, 09 Sep 2003 22:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni , Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, jimb@redhat.com Subject: Re: [rfa/6.0] Fix a thinko in dwarf2loc References: <20030801193245.GA2529@nevyn.them.org> <20030817205822.GD11300@nevyn.them.org> <20030824164855.GA17841@nevyn.them.org> <20030907041237.GB10340@nevyn.them.org> <16222.17838.527612.509356@localhost.redhat.com> <20030909212507.GA5686@nevyn.them.org> <16222.23051.280481.102836@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00188.txt.bz2 > > > > > > > + return baton.needs_frame || ctx->in_reg; > > > > > > > } > > > > > > > > > > > > > Hmmm, the ctx just got freed, you cannot dereference it. Need to use a > > > > Eek, I'm embarassed. You are so right. > > > > > local variable. What you are really saying here is that the > > > needs_frame variable is not sufficient to describe what's needed. Can > > > the case be added, so that needs_frame becomes OK? Proabably you > > > need another need_frame_* function. > > > > No, I can't. The needs_frame_* functions are hooks for things which > > are external to the expression evaluator - concepts like "object" and > > "thread local storage address" which require information. But the > > evaluator won't actually try to read from the register when parsing a > > DW_OP_reg1; it just sets in_reg. > > Oh, ok, I guess save ctx->in_reg in a local variable then. > > elena Thanks for picking this up. So there's no confusion I'm also ok with this on the branch. Andrew