From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8684 invoked by alias); 5 Sep 2003 14:21:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8442 invoked from network); 5 Sep 2003 14:21:25 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Sep 2003 14:21:25 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7ACF92B7F; Fri, 5 Sep 2003 10:21:11 -0400 (EDT) Message-ID: <3F589BD7.5080506@redhat.com> Date: Fri, 05 Sep 2003 14:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] New m32r remote target, m32rsdi References: <02e201c35a5e$883a8cb0$5169910a@KEI> <20030817210347.GF11300@nevyn.them.org> <01af01c3679d$25650650$5169910a@KEI> <012d01c37359$e3f98510$5169910a@KEI> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00061.txt.bz2 > Hello, > > I posted the following two weeks ago, but there is no reaction > so far. > > Its patch adds a new remote protocol to m32r architecture and > does not influence any other functions. So I think it's safe > to add. Dig dig, ah I see Daniel wrote: > I don't feel qualified to review a new remote target, so you'll have to > ask the remote maintainer. However, there's definitely a problem with > the new code. It's full of pieces like: > > if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > *((unsigned long *) (buf + 1)) = pc_addr; > else > *((unsigned long *) (buf + 1)) = pc_addr - 1; > > This sends host-endian data over the wire to the target. Run it on a > big-endian host and bad things will happen. I guess that means me (but I'm only listed for remote.c :-). I'll look over the revision. > I'm going to commit it next weak. Please let me know if there > is any problem. That wouldn't be a good idea. Andrew