From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-26722-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 11718 invoked by alias); 28 Aug 2003 15:39:56 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 11705 invoked from network); 28 Aug 2003 15:39:55 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 28 Aug 2003 15:39:55 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id B7DD42B7F; Thu, 28 Aug 2003 11:39:53 -0400 (EDT)
Message-ID: <3F4E2249.3040102@redhat.com>
Date: Thu, 28 Aug 2003 15:39:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Jacobowitz <drow@mvista.com>
Cc: "Nathan J. Williams" <nathanw@wasabisystems.com>,
	thorpej@wasabisystems.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] IBM6000_TARGET is wrong for NetBSD/powerpc
References: <mtuadabanvx.fsf@contents-vnder-pressvre.mit.edu> <20030828142351.GB2731@nevyn.them.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-08/txt/msg00510.txt.bz2

> 
> Hi Jason,
> 
> Did you see this patch?  It looks right to me, but you're the NetBSD
> maintainer :)

Unfortuatly not from a multi-arch point of view :-(  The number of 
#defines and #undefines should be overall decreasing.  Here, it would be 
better to either:

- re-arange tm-rs6000.h so that the define wasn't needed
- move the define to nm-rs6000.h (sick but effective :-)

Andrew


>> Index: tm-nbsd.h
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/config/powerpc/tm-nbsd.h,v
>> retrieving revision 1.2
>> diff -u -r1.2 tm-nbsd.h
>> --- tm-nbsd.h	22 May 2002 03:59:55 -0000	1.2
>> +++ tm-nbsd.h	14 Aug 2003 22:09:26 -0000
>> @@ -23,4 +23,8 @@
>>  
>>  #include "powerpc/tm-ppc-eabi.h"
>>  
>> +/* We _want_ the SVR4 section offset calculations (see syms_from_objfile()
>> +   in symfile.c) */
>> +#undef IBM6000_TARGET
>> +
>>  #endif /* TM_NBSD_H */
>> 
>> 
> 
> 
> -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer