From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23740 invoked by alias); 27 Aug 2003 19:37:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23731 invoked from network); 27 Aug 2003 19:37:09 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 27 Aug 2003 19:37:09 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 887A72B7F; Wed, 27 Aug 2003 15:37:11 -0400 (EDT) Message-ID: <3F4D0867.1000504@redhat.com> Date: Wed, 27 Aug 2003 19:37:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Jason Merrill , gdb-patches@sources.redhat.com Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name References: <3F4C2BFA.9000108@redhat.com> <3F4CC452.1060100@redhat.com> <20030827154638.GA17095@nevyn.them.org> <3F4CD4F5.9040302@redhat.com> <20030827160238.GA1011@nevyn.them.org> <3F4CD8F8.3060708@redhat.com> <20030827161623.GA3971@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00495.txt.bz2 >> That's a separate problem. That specific attribute should have gained a >> comment explaining how/why it is used by non-MIPS platforms. Otherwize >> no one knows what's about to hit them. > > > I have no idea what you mean by "hit". Care to expand? What would happen if MIPS was deleted. Presumably this attribute would be deleted along with the rest of the code (it looks mips specific and there's no commentary to suggest otherwize). Andrew