From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21056 invoked by alias); 27 Aug 2003 16:14:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20973 invoked from network); 27 Aug 2003 16:14:47 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 27 Aug 2003 16:14:47 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id EB3012B7F; Wed, 27 Aug 2003 12:14:48 -0400 (EDT) Message-ID: <3F4CD8F8.3060708@redhat.com> Date: Wed, 27 Aug 2003 16:14:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Jason Merrill , gdb-patches@sources.redhat.com Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name References: <3F4C2BFA.9000108@redhat.com> <3F4CC452.1060100@redhat.com> <20030827154638.GA17095@nevyn.them.org> <3F4CD4F5.9040302@redhat.com> <20030827160238.GA1011@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00477.txt.bz2 > On Wed, Aug 27, 2003 at 11:57:41AM -0400, Andrew Cagney wrote: > >> >Can you please find out. There must be a stronger rationale then "it's > >> >>been in my local tree for years". > >> > >> > >> >Well, the patch is certainly right. GCC generates >> >DW_AT_MIPS_linkage_name on all targets, and has for as far back as I >> >have GCC sources to check it. > >> >> Can you please add a comment explaining exactly when/where this occures >> then? Someone looking that that code is going to assume that >> DW_AT_MIPS_linkage_name is outside the #ifdef MIPS because of a >> host/target cross platform problem and _not_ because GCC uses it for all >> architectures. > > > Actually, I have no idea where the #ifdef MIPS came from, but it should > be removed. There's no reason to recognize extensions only on a > specific platform, and their other uses are not protected. That's a separate problem. That specific attribute should have gained a comment explaining how/why it is used by non-MIPS platforms. Otherwize no one knows what's about to hit them. Andrew