Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, kettenis@gnu.org
Subject: Re: RFA: Fix lin-lwp SIGINT handling for 2.6
Date: Wed, 27 Aug 2003 02:22:00 -0000	[thread overview]
Message-ID: <3F4C15D5.8080207@redhat.com> (raw)
In-Reply-To: <20030826193621.GA1925@nevyn.them.org>

Daniel Jacobowitz wrote:
> This patch fixes a number of inconsistent regressions in schedlock.exp and
> pthreads.exp on 2.6-series kernels, using LinuxThreads.  Red Hat 2.4 kernels
> have the same problems; the fix will work there too iff there is an update
> which exports ShdPnd in /proc.
> 
> The problem is that the SIGINT is delivered to every thread, and not
> properly flushed.  So we go later to step or continue and get an "echo" of
> the original SIGINT.  This is a timing problem caused by the introduction of
> two signal queues in the kernel; the SIGSTOP is now guaranteed to be
> delivered before the SIGINT, since it's on the thread-specific queue.  It
> used to be that SIGINT would be delivered first; they were on the same
> queue, and SIGINT was lower numbered.
> 
> So we have to check whether a SIGINT is pending (and not blocked/ignored)
> for the current thread after we stop it, and resume the thread to catch the
> SIGINT if so.
> 
> It's not a perfect fix, but it's enough more reliable than the current
> scheme that I haven't been able to reproduce the problems.  OK?  HEAD only;
> this is a bit of an annoyance, but too risky for the branch, IMO.
> 

I've been worried about that.

May I suggest that the function that opens a proc file belongs
in linux-proc.c?



  reply	other threads:[~2003-08-27  2:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-26 19:36 Daniel Jacobowitz
2003-08-27  2:22 ` Michael Snyder [this message]
2003-08-27  4:01   ` Daniel Jacobowitz
2003-08-27 17:42     ` Michael Snyder
2003-09-07 18:50       ` Daniel Jacobowitz
2003-08-27 18:14 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F4C15D5.8080207@redhat.com \
    --to=msnyder@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox