From: "J. Johnston" <jjohnstn@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: ia64 patch to handle predicated insns in prologue
Date: Tue, 26 Aug 2003 19:50:00 -0000 [thread overview]
Message-ID: <3F4BA737.7030805@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
The accompanying patch handles a bug in backtracing through glibc's sleep.
The compiler generates some predicated insns prior to saving the return register
b0 into a register stack register. The current code stops when it sees a
predicated insn. The change makes the prologue examination stop only if the
function is frameless or we have already seen the return register.
This removes a number of failures in gdb.threads caused when we catch another
thread in sleep and we try and backtrace.
Ok to commit?
-- Jeff J.
2003-08-26 Jeff Johnston <jjohnstn@redhat.com>
* ia64-tdep.c (examine_prologue): Only stop at predicated insns if
we are frameless or the return address register is already known.
[-- Attachment #2: ia64-tdep-predicated.patch --]
[-- Type: text/plain, Size: 996 bytes --]
Index: ia64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ia64-tdep.c,v
retrieving revision 1.94
diff -u -r1.94 ia64-tdep.c
--- ia64-tdep.c 26 Aug 2003 17:33:22 -0000 1.94
+++ ia64-tdep.c 26 Aug 2003 17:46:44 -0000
@@ -1143,11 +1143,18 @@
if (next_pc == 0)
break;
- if ((it == B && ((instr & 0x1e1f800003f) != 0x04000000000))
- || ((instr & 0x3fLL) != 0LL))
+ if (it == B && ((instr & 0x1e1f800003f) != 0x04000000000))
{
- /* Exit loop upon hitting a non-nop branch instruction
- or a predicated instruction. */
+ /* Exit loop upon hitting a non-nop branch instruction. */
+ if (trust_limit)
+ lim_pc = pc;
+ break;
+ }
+ else if (((instr & 0x3fLL) != 0LL) &&
+ (frameless || ret_reg != 0))
+ {
+ /* Exit loop upon hitting a predicated instruction if
+ we already have the return register or if we are frameless. */
if (trust_limit)
lim_pc = pc;
break;
next reply other threads:[~2003-08-26 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 19:50 J. Johnston [this message]
2003-08-26 20:10 ` Kevin Buettner
2003-08-26 22:26 ` J. Johnston
2003-08-26 22:36 ` Kevin Buettner
2003-08-27 18:26 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F4BA737.7030805@redhat.com \
--to=jjohnstn@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox